sdk/lib/_internal/compiler/implementation/ssa/optimize.dart - Issue 11415028: Remove NullPointerException.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

Issue 11415028: Remove NullPointerException. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Added analyzer co19 expectations. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart b/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

index 6333b0e147d6325fa4013090c8fdf40c83f7f00c..1c28b5305108ee8e450e49179bc951a63a57aa0c 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

@@ -751,7 +751,7 @@ class SsaDeadCodeEliminator extends HGraphVisitor implements OptimizationPhase {

return !instruction.hasSideEffects(types)

&& instruction.usedBy.isEmpty

// A dynamic getter that has no side effect can still throw

- // a NoSuchMethodError or a NullPointerException.

+ // a NoSuchMethodError

ngeoffray 2012/11/16 12:41:30 Keep the '.' at the end.

Lasse Reichstein Nielsen 2012/11/16 15:32:23 Well spotted!

&& instruction is !HInvokeDynamicGetter

&& instruction is !HCheck

&& instruction is !HTypeGuard