runtime/lib/string.cc - Issue 11415028: Remove NullPointerException.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/string.cc

Issue 11415028: Remove NullPointerException. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed review comments. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/lib/string.cc

diff --git a/runtime/lib/string.cc b/runtime/lib/string.cc

index 76c097abc54cdf991dc46ceba8ff8400caf2ceef..ae13fd63e8c1d9b479f554b56ef68d64c02f4535 100644

--- a/runtime/lib/string.cc

+++ b/runtime/lib/string.cc

@@ -146,7 +146,7 @@ DEFINE_NATIVE_ENTRY(Strings_concatAll, 1) {

elem ^= strings.At(i);

if (elem.IsNull()) {

GrowableArray<const Object*> args;

- Exceptions::ThrowByType(Exceptions::kNullPointer, args);

+ Exceptions::ThrowByType(Exceptions::kNullThrown, args);

}

if (!elem.IsString()) {

GrowableArray<const Object*> args;