Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1141493002: Gracefully handle tab update events for closing tabs. (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gracefully handle tab update events for closing tabs. When we close a tab that shows a modal dialog, and another tab has a modal dialog pending, we'll end up deactivating the first tab after closing it. In that case, just ignore the event. BUG=484550 R=kalman@chromium.org Committed: https://crrev.com/d13e9be5142a6df82fa9fc12ec4708526ce83f38 Cr-Commit-Position: refs/heads/master@{#329541}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/extensions/api/tabs/tabs_event_router.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years, 7 months ago (2015-05-12 02:40:40 UTC) #1
not at google - send to devlin
lgtm
5 years, 7 months ago (2015-05-12 20:46:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141493002/1
5 years, 7 months ago (2015-05-13 00:25:09 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 00:29:55 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 00:30:52 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d13e9be5142a6df82fa9fc12ec4708526ce83f38
Cr-Commit-Position: refs/heads/master@{#329541}

Powered by Google App Engine
This is Rietveld 408576698