Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 1141483002: Roll gn to 329298 (Closed)

Created:
5 years, 7 months ago by Dirk Pranke
Modified:
5 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools b0ede9c8:b73e4f70 to roll GN 66e43703:63d951b0 (328870:329298) This picks up the following change: 22d6ca18 GN: Don't generate phony rules called "all". TBR=brettw@chromium.org CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel;tryserver.chromium.win:win8_chromium_gn_rel Committed: https://crrev.com/3ee04f75d60e967afa4f49b9a08ef78be5f61a71 Cr-Commit-Position: refs/heads/master@{#329328}

Patch Set 1 #

Patch Set 2 : Actual roll #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141483002/20001
5 years, 7 months ago (2015-05-12 01:11:04 UTC) #3
commit-bot: I haz the power
Transient error: Too many "tryserver.chromium.mac:mac_chromium_gn_rel,tryserver.chromium.win:win8_chromium_gn_rel" delimiters in ":". Correct syntax is "tryserver:bot1,bot2;tryserver2:bot3,bot4;".
5 years, 7 months ago (2015-05-12 01:11:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141483002/20001
5 years, 7 months ago (2015-05-12 01:34:46 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-12 02:26:42 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 02:27:34 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3ee04f75d60e967afa4f49b9a08ef78be5f61a71
Cr-Commit-Position: refs/heads/master@{#329328}

Powered by Google App Engine
This is Rietveld 408576698