Issue 1141453005: Remove use of deprecated DelayedSocketData gcm_unit_test.

Issue 1141453005: Remove use of deprecated DelayedSocketData gcm_unit_test. (Closed)

Created:
5 years, 7 months ago by Ryan Hamilton

Modified:
5 years, 7 months ago

Reviewers:
Nicolas Zea, Dmitry Titov

CC:
chromium-reviews, zea+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Remove use of deprecated DelayedSocketData gcm_unit_test. Committed: https://crrev.com/fc092256287403e7326635e2a818a00d43269947 Cr-Commit-Position: refs/heads/master@{#330814}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -19 lines)			Patch
	M	google_apis/gcm/base/socket_stream_unittest.cc	View		4 chunks	+5 lines, -11 lines	0 comments	Download
	M	google_apis/gcm/engine/connection_handler_impl_unittest.cc	View		4 chunks	+7 lines, -8 lines	0 comments	Download

Total messages: 12 (4 generated)

Ryan Hamilton

dimich: can you please take a look? This should be a very quick review.

5 years, 7 months ago (2015-05-20 13:36:29 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141453005/1

5 years, 7 months ago (2015-05-20 21:11:13 UTC) #10

commit-bot: I haz the power

5 years, 7 months ago (2015-05-20 22:14:36 UTC) #12

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/fc092256287403e7326635e2a818a00d43269947
Cr-Commit-Position: refs/heads/master@{#330814}