Fix setting the top-level FrameTreeNode name for named windows.

content/browser/web_contents/web_contents_impl_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "content/browser/frame_host/navigation_entry_impl.h"
 #include "content/browser/renderer_host/render_widget_host_impl.h"
 #include "content/browser/web_contents/web_contents_impl.h"
 #include "content/browser/web_contents/web_contents_view.h"
@@ skipping 669 matching lines @@
   // Simulate widget is entering fullscreen (changing size is enough).
   shell()->web_contents()->GetRenderViewHost()->WasResized();
 
   ASSERT_TRUE(ExecuteScript(shell()->web_contents(),
                             "document.title = "
                             " window.matchMedia('(display-mode:"
                             " fullscreen)').matches"));
   EXPECT_EQ(base::ASCIIToUTF16("true"), shell()->web_contents()->GetTitle());
 }
 
+IN_PROC_BROWSER_TEST_F(WebContentsImplBrowserTest, NewNamedWindow) {
+  ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
+
+  GURL url = embedded_test_server()->GetURL("/click-noreferrer-links.html");
+  NavigateToURL(shell(), url);

[alexmos, 2015/05/12 21:22:30]

nit: EXPECT_TRUE around NavigateToURL?  (note to self: need to find some time to
finish 425335...)

[nasko, 2015/05/12 21:58:21]

Done.

+
+  {
+    ShellAddedObserver new_shell_observer;
+
+    // Open a new, named window.
+    EXPECT_TRUE(ExecuteScript(shell()->web_contents(),
+                              "window.open('about:blank','new_window');"));
+
+    Shell* new_shell = new_shell_observer.GetShell();
+    WaitForLoadStop(new_shell->web_contents());
+
+    EXPECT_EQ("new_window",
+              static_cast<WebContentsImpl*>(new_shell->web_contents())
+                  ->GetFrameTree()->root()->frame_name());

[alexmos, 2015/05/12 21:22:30]

Does the name also make it over to the new window's renderer?  Would it make
sense to check "window.name" in the new_shell, and/or try this with a
window.open for a cross-site URL?

[nasko, 2015/05/12 21:58:21]

The window.open with cross-site URL should be already covered by all of our
cross-process postMessage tests, right? I've added the window.name test, since
it is a useful thing to check.

[alexmos, 2015/05/12 23:04:30]

Right, makes sense, thanks!

+  }
+
+  {
+    ShellAddedObserver new_shell_observer;
+
+    // Test clicking a target=foo link.
+    bool success = false;
+    EXPECT_TRUE(ExecuteScriptAndExtractBool(
+        shell()->web_contents(),
+        "window.domAutomationController.send(clickSameSiteTargetedLink());",
+        &success));
+    EXPECT_TRUE(success);
+
+    Shell* new_shell = new_shell_observer.GetShell();
+    WaitForLoadStop(new_shell->web_contents());
+
+    EXPECT_EQ("foo",
+              static_cast<WebContentsImpl*>(new_shell->web_contents())
+                  ->GetFrameTree()->root()->frame_name());
+  }
+}
+
 }  // namespace content