Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 1141453002: Makes browser resize content when root bounds change (Closed)

Created:
5 years, 7 months ago by sky
Modified:
5 years, 7 months ago
CC:
chromium-reviews, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes browser resize content when root bounds change Without this on android we don't open the browser to fill the screen, nor resize when the rotation changes. R=ben@chromium.org BUG=none TEST=none Committed: https://crrev.com/def5bc678d239fc917f6f6a996bb89a407932e29 Cr-Commit-Position: refs/heads/master@{#329289}

Patch Set 1 #

Total comments: 1

Patch Set 2 : move to androidui #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -14 lines) Patch
M mandoline/ui/browser/android/android_ui.h View 1 3 chunks +8 lines, -1 line 0 comments Download
M mandoline/ui/browser/android/android_ui.cc View 1 2 chunks +14 lines, -1 line 0 comments Download
M mandoline/ui/browser/browser.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M mandoline/ui/browser/browser.cc View 1 3 chunks +11 lines, -10 lines 0 comments Download
M mandoline/ui/browser/browser_ui.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
sky
https://codereview.chromium.org/1141453002/diff/1/mandoline/ui/browser/browser.cc File mandoline/ui/browser/browser.cc (right): https://codereview.chromium.org/1141453002/diff/1/mandoline/ui/browser/browser.cc#newcode41 mandoline/ui/browser/browser.cc:41: void Browser::ReplaceContentWithURL(const mojo::String& url) { I moved a couple ...
5 years, 7 months ago (2015-05-11 22:01:27 UTC) #1
Ben Goodger (Google)
Can you implement this in AndroidUI? DesktopUI already does this.
5 years, 7 months ago (2015-05-11 22:45:45 UTC) #2
Ben Goodger (Google)
On 2015/05/11 22:45:45, Ben Goodger (Google) wrote: > Can you implement this in AndroidUI? DesktopUI ...
5 years, 7 months ago (2015-05-11 22:46:17 UTC) #3
sky
Done.
5 years, 7 months ago (2015-05-11 23:11:32 UTC) #4
Ben Goodger (Google)
lgtm
5 years, 7 months ago (2015-05-11 23:57:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141453002/20001
5 years, 7 months ago (2015-05-12 00:06:19 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-12 00:12:43 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 00:13:56 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/def5bc678d239fc917f6f6a996bb89a407932e29
Cr-Commit-Position: refs/heads/master@{#329289}

Powered by Google App Engine
This is Rietveld 408576698