Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart

Issue 1141443002: suggest keywords for more expressions (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/completion/keyword_contributor_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart b/pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart
index 5414bcc3fd644de18dcce4dfa1c6f4909af0d5fb..7a8763bd47b98c9a3c2d80621c55f8289d5d8ed8 100644
--- a/pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart
+++ b/pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart
@@ -128,6 +128,11 @@ class _KeywordVisitor extends GeneralizingAstVisitor {
}
@override
+ visitExpression(Expression node) {
+ _addExpressionKeywords(node);
+ }
+
+ @override
visitExpressionFunctionBody(ExpressionFunctionBody node) {
if (entity == node.expression) {
_addExpressionKeywords(node);
@@ -199,6 +204,25 @@ class _KeywordVisitor extends GeneralizingAstVisitor {
}
@override
+ visitPrefixedIdentifier(PrefixedIdentifier node) {
+ if (entity != node.identifier) {
+ _addExpressionKeywords(node);
+ }
+ }
+
+ @override
+ visitReturnStatement(ReturnStatement node) {
+ if (entity == node.expression) {
+ _addExpressionKeywords(node);
+ }
+ }
+
+ @override
+ visitStringLiteral(StringLiteral node) {
+ // ignored
+ }
+
+ @override
visitSwitchStatement(SwitchStatement node) {
if (entity == node.expression) {
_addExpressionKeywords(node);
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/completion/keyword_contributor_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698