Issue 11414304: Fleshes out the basic set of focus rules a bit more.

Issue 11414304: Fleshes out the basic set of focus rules a bit more. (Closed)

Created:
8 years ago by Ben Goodger (Google)

Modified:
8 years ago

Reviewers:
sadrul

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fleshes out the basic set of focus rules a bit more. http://crbug.com/162100 R=sadrul@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170988

Patch Set 5 : #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+170 lines, -40 lines)			Patch
M	ash/wm/ash_focus_rules.h	View	1 2 3 4	1 chunk	+6 lines, -8 lines	0 comments	Download
M	ash/wm/ash_focus_rules.cc	View	1 2 3 4	2 chunks	+66 lines, -16 lines	0 comments	Download
M	ui/views/corewm/base_focus_rules.h	View	1 2 3 4	1 chunk	+7 lines, -2 lines	0 comments	Download
M	ui/views/corewm/base_focus_rules.cc	View	1 2 3 4	2 chunks	+78 lines, -12 lines	0 comments	Download
M	ui/views/corewm/focus_controller_unittest.cc	View	1 2 3 4	1 chunk	+6 lines, -2 lines	0 comments	Download
M	ui/views/corewm/window_modality_controller.h	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/views/corewm/window_modality_controller.cc	View	1 2 3 4	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

Makes BaseFocusRules/AshFocusRules more closely match my understanding of the way this stuff works in the ...

8 years ago (2012-12-04 04:36:26 UTC) #1

sadrul

https://codereview.chromium.org/11414304/diff/6004/ash/wm/ash_focus_rules.cc File ash/wm/ash_focus_rules.cc (right): https://codereview.chromium.org/11414304/diff/6004/ash/wm/ash_focus_rules.cc#newcode61 ash/wm/ash_focus_rules.cc:61: Perhaps return false earlier here if window->id() == _DefaultContainer ...

8 years ago (2012-12-04 16:19:40 UTC) #2

Ben Goodger (Google)

8 years ago (2012-12-04 16:37:10 UTC) #4

https://codereview.chromium.org/11414304/diff/6004/ui/views/corewm/window_mod...
File ui/views/corewm/window_modality_controller.cc (right):

https://codereview.chromium.org/11414304/diff/6004/ui/views/corewm/window_mod...
ui/views/corewm/window_modality_controller.cc:80: return
GetModalTransientChild(activatable, activatable);
Cannot. Results in recursion in CanActivateWindow().

Expand Messages | Collapse Messages