Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: chrome/browser/extensions/api/omnibox/omnibox_apitest.cc

Issue 11414303: Make Google Search autocomplete provider cursor aware. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Addressed comments. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/omnibox/omnibox_apitest.cc
diff --git a/chrome/browser/extensions/api/omnibox/omnibox_apitest.cc b/chrome/browser/extensions/api/omnibox/omnibox_apitest.cc
index 1ba2f4b2d3c3fb02104d09282f838d679c9e564e..c81ee3aae106239872880522149700a0f1ac342f 100644
--- a/chrome/browser/extensions/api/omnibox/omnibox_apitest.cc
+++ b/chrome/browser/extensions/api/omnibox/omnibox_apitest.cc
@@ -83,8 +83,8 @@ IN_PROC_BROWSER_TEST_F(OmniboxApiTest, DISABLED_Basic) {
// it.
{
autocomplete_controller->Start(
- ASCIIToUTF16("keywor"), string16(), true, false, true,
- AutocompleteInput::ALL_MATCHES);
+ AutocompleteInput(ASCIIToUTF16("keywor"), string16::npos, string16(),
+ true, false, true, AutocompleteInput::ALL_MATCHES));
WaitForAutocompleteDone(autocomplete_controller);
EXPECT_TRUE(autocomplete_controller->done());
@@ -104,8 +104,9 @@ IN_PROC_BROWSER_TEST_F(OmniboxApiTest, DISABLED_Basic) {
// Test that our extension can send suggestions back to us.
{
autocomplete_controller->Start(
- ASCIIToUTF16("keyword suggestio"), string16(), true, false, true,
- AutocompleteInput::ALL_MATCHES);
+ AutocompleteInput(ASCIIToUTF16("keyword suggestio"), string16::npos,
+ string16(), true, false, true,
+ AutocompleteInput::ALL_MATCHES));
WaitForAutocompleteDone(autocomplete_controller);
EXPECT_TRUE(autocomplete_controller->done());
@@ -213,8 +214,9 @@ IN_PROC_BROWSER_TEST_F(OmniboxApiTest, DISABLED_PopupStaysClosed) {
// directly, figure out how to send it via the proper calls to
// location_bar or location_bar->().
autocomplete_controller->Start(
- ASCIIToUTF16("keyword command"), string16(), true, false, true,
- AutocompleteInput::ALL_MATCHES);
+ AutocompleteInput(ASCIIToUTF16("keyword command"), string16::npos,
+ string16(), true, false, true,
+ AutocompleteInput::ALL_MATCHES));
location_bar->AcceptInput();
WaitForAutocompleteDone(autocomplete_controller);
EXPECT_TRUE(autocomplete_controller->done());
@@ -252,8 +254,9 @@ IN_PROC_BROWSER_TEST_F(OmniboxApiTest, DISABLED_IncognitoSplitMode) {
// Test that we get the incognito-specific suggestions.
{
autocomplete_controller->Start(
- ASCIIToUTF16("keyword suggestio"), string16(), true, false, true,
- AutocompleteInput::ALL_MATCHES);
+ AutocompleteInput(ASCIIToUTF16("keyword suggestio"), string16::npos,
+ string16(), true, false, true,
+ AutocompleteInput::ALL_MATCHES));
WaitForAutocompleteDone(autocomplete_controller);
EXPECT_TRUE(autocomplete_controller->done());
@@ -273,8 +276,9 @@ IN_PROC_BROWSER_TEST_F(OmniboxApiTest, DISABLED_IncognitoSplitMode) {
{
ResultCatcher catcher;
autocomplete_controller->Start(
- ASCIIToUTF16("keyword command incognito"), string16(),
- true, false, true, AutocompleteInput::ALL_MATCHES);
+ AutocompleteInput(ASCIIToUTF16("keyword command incognito"),
+ string16::npos, string16(), true, false, true,
+ AutocompleteInput::ALL_MATCHES));
location_bar->AcceptInput();
EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
}

Powered by Google App Engine
This is Rietveld 408576698