Make Google Search autocomplete provider cursor aware.

chrome/browser/autocomplete/history_provider.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/history_provider.h"
 
 #include <string>
 
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
@@ skipping 116 matching lines @@
   const size_t num_output_slashes =
       (last_output_nonslash == string16::npos) ?
       output.length() : (output.length() - 1 - last_output_nonslash);
   if (num_output_slashes < num_input_slashes)
     output.append(num_input_slashes - num_output_slashes, '/');
   else if (num_output_slashes > num_input_slashes)
     output.erase(output.length() - num_output_slashes + num_input_slashes);
 
   url_parse::Parsed parts;
   URLFixerUpper::SegmentURL(output, &parts);
-  input->UpdateText(output, parts);
+  // TODO: Rather then risking bogus cursor location, we simply pretend it was
+  // not set.  It should be fine as long as the current implementation is not
+  // cursor aware (which is true as of Nov 2012).

[Peter Kasting, 2012/12/05 20:49:38]

We probably should do the right thing here, since Mark wants to make the history
system cursor-aware (separate bug on file).  We can mostly handle things with
manual adjustments or using the conversion functions in
utf_offset_conversions.h.  The big piece is that we probably have to make
FixupURL() handle offset adjustment, which is nasty.

This could all be done as a separate change to limit scope creep.  In that case
I'd change the TODO text here to refer to what needs to be done.

[Bart N., 2012/12/06 21:43:32]

Done.

+  input->UpdateText(output, string16::npos, parts);
   return !output.empty();
 }
 
 // static
 size_t HistoryProvider::TrimHttpPrefix(string16* url) {
   // Find any "http:".
   if (!HasHTTPScheme(*url))
     return 0;
   size_t scheme_pos =
       url->find(ASCIIToUTF16(chrome::kHttpScheme) + char16(':'));
   DCHECK_NE(string16::npos, scheme_pos);
 
   // Erase scheme plus up to two slashes.
   size_t prefix_end = scheme_pos + strlen(chrome::kHttpScheme) + 1;
   const size_t after_slashes = std::min(url->length(), prefix_end + 2);
   while ((prefix_end < after_slashes) && ((*url)[prefix_end] == '/'))
     ++prefix_end;
   url->erase(scheme_pos, prefix_end - scheme_pos);
   return (scheme_pos == 0) ? prefix_end : 0;
 }
 
 // static
 bool HistoryProvider::PreventInlineAutocomplete(
     const AutocompleteInput& input) {
   return input.prevent_inline_autocomplete() ||
       always_prevent_inline_autocomplete_ ||
       (!input.text().empty() &&
        IsWhitespace(input.text()[input.text().length() - 1]));
 }