Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 11414302: Roll Skia DEPS to r6659 & remove suppressions (Closed)

Created:
8 years ago by robertphillips
Modified:
8 years ago
Reviewers:
reed1
CC:
chromium-reviews, skia-dev_google.com
Visibility:
Public.

Description

Roll Skia DEPS to r6659 & remove suppressions control: https://codereview.chromium.org/11428152/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -65 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M skia/skia.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M skia/skia_test_expectations.txt View 1 chunk +0 lines, -58 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
robertphillips
8 years ago (2012-12-04 13:04:47 UTC) #1
All the layout tests are broken. I have linux & mac trybots out to see if it was
the removal of SK_DISABLE_SEPARABLE_MASK_BLUR from the gyp file. Of the
non-layout tests the only discrepancies between the roll and control were:

win
   roll:    
            device_unittests failed 1
            browser_tests 13 flaky failed 8
                AppProcess
                PRE_TranslateSessionRestore
                TranslateSessionRestore
                FLAKY_URLRequest_CreateAndIsURLRequestInfo
                Graphics2D_Humongous
                Graphics2D_InvalidSize
                FLAKY_GatherStatistics
                WindowsApi
            chrome_frame_tests 33 disabled 26 flaky failed 1
                WidgetModeIE_CFInstanceFallback
   control: 
            green

Powered by Google App Engine
This is Rietveld 408576698