Fix a number of int type issues in dart:io File implementation to avoid implicit conversions that c…

runtime/bin/dartutils.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/dartutils.h"
 
 #include "bin/extensions.h"
 #include "bin/directory.h"
 #include "bin/file.h"
 #include "include/dart_api.h"
@@ skipping 47 matching lines @@
 
 int64_t DartUtils::GetIntegerValue(Dart_Handle value_obj) {
   ASSERT(Dart_IsInteger(value_obj));
   int64_t value = 0;
   Dart_Handle result = Dart_IntegerToInt64(value_obj, &value);
   ASSERT(!Dart_IsError(result));
   return value;
 }
 
 
+intptr_t DartUtils::GetIntptrValue(Dart_Handle value_obj) {
+  ASSERT(Dart_IsInteger(value_obj));
+  int64_t value = 0;
+  Dart_Handle result = Dart_IntegerToInt64(value_obj, &value);
+  ASSERT(!Dart_IsError(result));
+  return static_cast<intptr_t>(value);
+}
+
+
 bool DartUtils::GetInt64Value(Dart_Handle value_obj, int64_t* value) {
   bool valid = Dart_IsInteger(value_obj);
   if (valid) {
     Dart_Handle result = Dart_IntegerFitsIntoInt64(value_obj, &valid);
     ASSERT(!Dart_IsError(result));
   }
   if (!valid) return false;
   Dart_Handle result = Dart_IntegerToInt64(value_obj, value);
   ASSERT(!Dart_IsError(result));
   return true;
@@ skipping 559 matching lines @@
 
 
 Dart_CObject* CObject::NewUint8Array(int length) {
   Dart_CObject* cobject = New(Dart_CObject::kUint8Array, length);
   cobject->value.as_byte_array.length = length;
   cobject->value.as_byte_array.values = reinterpret_cast<uint8_t*>(cobject + 1);
   return cobject;
 }
 
 
-Dart_CObject* CObject::NewExternalUint8Array(int length,
+Dart_CObject* CObject::NewExternalUint8Array(int64_t length,
                                              uint8_t* data,
                                              void* peer,
                                              Dart_PeerFinalizer callback) {
   Dart_CObject* cobject = New(Dart_CObject::kExternalUint8Array);
   cobject->value.as_external_byte_array.length = length;
   cobject->value.as_external_byte_array.data = data;
   cobject->value.as_external_byte_array.peer = peer;
   cobject->value.as_external_byte_array.callback = callback;
   return cobject;
 }
@@ skipping 25 matching lines @@
 
 CObject* CObject::NewOSError(OSError* os_error) {
   CObject* error_message =
       new CObjectString(CObject::NewString(os_error->message()));
   CObjectArray* result = new CObjectArray(CObject::NewArray(3));
   result->SetAt(0, new CObjectInt32(CObject::NewInt32(kOSError)));
   result->SetAt(1, new CObjectInt32(CObject::NewInt32(os_error->code())));
   result->SetAt(2, error_message);
   return result;
 }