Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Side by Side Diff: runtime/bin/builtin_natives.cc

Issue 11414293: Fix a number of int type issues in dart:io File implementation to avoid implicit conversions that c… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/bin/dartutils.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "bin/builtin.h" 5 #include "bin/builtin.h"
6 6
7 #include <stdlib.h> 7 #include <stdlib.h>
8 #include <string.h> 8 #include <string.h>
9 9
10 #include "bin/dartutils.h" 10 #include "bin/dartutils.h"
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 Dart_ExitScope(); 105 Dart_ExitScope();
106 } 106 }
107 107
108 108
109 void FUNCTION_NAME(Exit)(Dart_NativeArguments args) { 109 void FUNCTION_NAME(Exit)(Dart_NativeArguments args) {
110 Dart_EnterScope(); 110 Dart_EnterScope();
111 int64_t status = 0; 111 int64_t status = 0;
112 // Ignore result if passing invalid argument and just exit 0. 112 // Ignore result if passing invalid argument and just exit 0.
113 DartUtils::GetInt64Value(Dart_GetNativeArgument(args, 0), &status); 113 DartUtils::GetInt64Value(Dart_GetNativeArgument(args, 0), &status);
114 Dart_ExitScope(); 114 Dart_ExitScope();
115 exit(status); 115 exit(static_cast<int>(status));
116 } 116 }
OLDNEW
« no previous file with comments | « no previous file | runtime/bin/dartutils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698