Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6418)

Unified Diff: chrome/test/chromedriver/test.py

Issue 11414267: Fix finding chrome binary for ChromeDriver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/test.py
diff --git a/chrome/test/chromedriver/test.py b/chrome/test/chromedriver/test.py
index 488b47a4bf8849a4a327b163855a0a1527edda80..2a43f3a934f658cf5e71910f79d09e976520bc06 100644
--- a/chrome/test/chromedriver/test.py
+++ b/chrome/test/chromedriver/test.py
@@ -16,15 +16,18 @@ class ChromeDriverTest(unittest.TestCase):
"""End to end tests for ChromeDriver."""
def testStartStop(self):
- driver = chromedriver.ChromeDriver(_CHROMEDRIVER_LIB)
+ driver = chromedriver.ChromeDriver(_CHROMEDRIVER_LIB, _CHROME_BINARY)
driver.Quit()
if __name__ == '__main__':
- if len(sys.argv) != 2:
- print 'Usage: %s <path_to_chromedriver_so>' % __file__
+ if len(sys.argv) != 3:
+ print ('Usage: %s <path_to_chromedriver_so> <path_to_chrome_binary>' %
+ __file__)
sys.exit(1)
global _CHROMEDRIVER_LIB
_CHROMEDRIVER_LIB = os.path.abspath(sys.argv[1])
+ global _CHROME_BINARY
+ _CHROME_BINARY = os.path.abspath(sys.argv[2])
all_tests_suite = unittest.defaultTestLoader.loadTestsFromModule(
sys.modules[__name__])
result = unittest.TextTestRunner().run(all_tests_suite)
« chrome/test/chromedriver/run_all_tests.py ('K') | « chrome/test/chromedriver/run_all_tests.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698