Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 11414259: Merge 135578 - REGRESSION (r128633): td changes size during re-layout of table although it shouldn't (Closed)

Created:
8 years ago by jochen (gone - plz use gerrit)
Modified:
8 years ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Visibility:
Public.

Description

Merge 135578 - REGRESSION (r128633): td changes size during re-layout of table although it shouldn't https://bugs.webkit.org/show_bug.cgi?id=102802 Patch by Julian Pastarmov <pastarmovj@chromium.org>; on 2012-11-23 Reviewed by Ojan Vafai. Source/WebCore: The bug was caused by incorrectly rewriting a nested condition which caused the else clause to trigger in wrong cases. Test: fast/table/nested-tables-with-div-offset.html * rendering/RenderBox.cpp: (WebCore::RenderBox::computePercentageLogicalHeight): Reverted wrong combination of nested if statements. LayoutTests: This test checks that table layout of some nested tables in quirks mode is computed correctly. * fast/table/nested-tables-with-div-offset-expected.txt: Added. * fast/table/nested-tables-with-div-offset.html: Added. TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136241

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
A + LayoutTests/fast/table/nested-tables-with-div-offset.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/table/nested-tables-with-div-offset-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/rendering/RenderBox.cpp View 1 chunk +20 lines, -18 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jochen (gone - plz use gerrit)
8 years ago (2012-11-30 15:30:22 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698