Issue 11414252: Add focus rules for Ash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11414252: Add focus rules for Ash. (Closed)

Created:
8 years ago by Ben Goodger (Google)

Modified:
8 years ago

Reviewers:
sadrul

CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, ben+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add focus rules for Ash. They are empty for now. I will begin migrating code over from ActivationController once I have a flag to turn this on. http://crbug.com/162100 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170479

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -0 lines)			Patch
M	ash/ash.gyp	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
A	ash/wm/ash_focus_rules.h	View	1 2 3	1 chunk	+36 lines, -0 lines	0 comments	Download
A	ash/wm/ash_focus_rules.cc	View	1 2 3	1 chunk	+50 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

Redirecting to sadrul since I think sky may be out today.

8 years ago (2012-11-30 16:46:24 UTC) #2

sadrul

8 years ago (2012-11-30 17:10:12 UTC) #3

LGTM

https://codereview.chromium.org/11414252/diff/5022/ash/wm/ash_focus_rules.cc
File ash/wm/ash_focus_rules.cc (right):

https://codereview.chromium.org/11414252/diff/5022/ash/wm/ash_focus_rules.cc#...
ash/wm/ash_focus_rules.cc:30: return activatable->Contains(window) &&
window->CanFocus();
Can |activatable| (or |window|) be NULL?

Expand Messages | Collapse Messages