runtime/vm/scanner.cc - Issue 11414249: Move various top-level Unicode definitions into classes and methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/scanner.cc

Issue 11414249: Move various top-level Unicode definitions into classes and methods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: address review comments Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/scanner.cc

diff --git a/runtime/vm/scanner.cc b/runtime/vm/scanner.cc

index 26920c656b484a8e34e28110b5ce6fe95d6ddb3e..f969fde067ba35c84a403714ca8f525b18025f8f 100644

--- a/runtime/vm/scanner.cc

+++ b/runtime/vm/scanner.cc

@@ -521,8 +521,8 @@ void Scanner::ScanEscapedCodePoint(int32_t* code_point) {

}

if (is_valid &&

- ((*code_point > 0x10FFFF) ||

- ((*code_point & 0xFFFFF800) == 0xD800))) {

+ ((Utf::IsOutOfRange(*code_point) ||

+ (Utf16::IsSurrogate(*code_point))))) {

ErrorMsg("invalid code point");

}

« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/unicode.h » ('j') | no next file with comments »