Issue 11414243: interactive autocomplete dialog - fill in shipping name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11414243: interactive autocomplete dialog - fill in shipping name (Closed)

Created:
8 years ago by Evan Stade

Modified:
8 years ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, dhollowa+watch_chromium.org, dbeam+watch-autofill_chromium.org, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

interactive autocomplete dialog - fill in shipping name shipping name has to come from the credit card name when "use billing for shipping" is checked. BUG=157270 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171033

Patch Set 1 #

Patch Set 2 : sync'd #

Patch Set 3 : fix sync #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -13 lines)			Patch
	M	chrome/browser/ui/autofill/autofill_dialog_controller.cc	View	1	2 chunks	+23 lines, -13 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ilya Sherman

Why does the shipping name need to come from the CC name when using billing ...

8 years ago (2012-11-30 01:08:27 UTC) #2

Ilya Sherman

Ok, I see that the billing address doesn't include a name, so LGTM I guess... ...

8 years ago (2012-11-30 01:18:45 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/11414243/5010

8 years ago (2012-12-04 00:59:00 UTC) #4

commit-bot: I haz the power

8 years ago (2012-12-04 02:52:27 UTC) #5

Retried try job too often on mac_rel for step(s) unit_tests

Expand Messages | Collapse Messages