Add Chrome OS accessibility histograms.

Re-land: Add Chrome OS accessibility histograms.

BUG=99504
TBR=joi

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170786

[dmazzoni, 2012-11-29 17:23:11]

joi: content/public
nkostylev: chrome/browser/chromeos

[Nikita (slow), 2012-11-29 18:29:23]

lgtm

https://codereview.chromium.org/11414232/diff/1/chrome/browser/chromeos/acces...
File chrome/browser/chromeos/accessibility/accessibility_util.cc (right):

https://codereview.chromium.org/11414232/diff/1/chrome/browser/chromeos/acces...
chrome/browser/chromeos/accessibility/accessibility_util.cc:114:
UMA_HISTOGRAM_BOOLEAN("Accessibility.CrosSpokenFeedback",
Should you also report histograms if users enable/disable CrosSpokenFeedback
during session but that is disabled on boot/initialize?

[dmazzoni, 2012-11-29 18:32:33]

On 2012/11/29 18:29:23, Nikita Kostylev wrote:
> Should you also report histograms if users enable/disable CrosSpokenFeedback
> during session but that is disabled on boot/initialize?

Note that this runs ~45 seconds after boot, so the idea is to catch people who
use it most of the time. It might miss some people who use accessibility
features only occasionally, but I'm not sure the best way to count those
accurately.

[commit-bot: I haz the power, 2012-11-30 08:07:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/11414232/5002

[commit-bot: I haz the power, 2012-11-30 08:07:13]

Failed to apply patch for
chrome/browser/chromeos/accessibility/accessibility_util.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/chromeos/accessibility/accessibility_util.cc
  Hunk #2 FAILED at 29.
  Hunk #3 succeeded at 112 (offset 3 lines).
  Hunk #4 FAILED at 263.
  2 out of 4 hunks FAILED -- saving rejects to file
chrome/browser/chromeos/accessibility/accessibility_util.cc.rej

Patch:       chrome/browser/chromeos/accessibility/accessibility_util.cc
Index: chrome/browser/chromeos/accessibility/accessibility_util.cc
diff --git a/chrome/browser/chromeos/accessibility/accessibility_util.cc
b/chrome/browser/chromeos/accessibility/accessibility_util.cc
index
2340e75a223f961cced1a70624e30f2ecf9abe06..ca58c196fddec08fe687d51621adc060c50b0448
100644
--- a/chrome/browser/chromeos/accessibility/accessibility_util.cc
+++ b/chrome/browser/chromeos/accessibility/accessibility_util.cc
@@ -13,6 +13,7 @@
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/logging.h"
+#include "base/metrics/histogram.h"
 #include "chrome/browser/accessibility/accessibility_extension_api.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chromeos/accessibility/magnification_manager.h"
@@ -28,6 +29,7 @@
 #include "chrome/common/extensions/extension_resource.h"
 #include "chrome/common/extensions/user_script.h"
 #include "chrome/common/pref_names.h"
+#include "content/public/browser/browser_accessibility_state.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
@@ -108,6 +110,23 @@ class ContentScriptLoader {
   std::queue<ExtensionResource> resources_;
 };
 
+void UpdateChromeOSAccessibilityHistograms() {
+  UMA_HISTOGRAM_BOOLEAN("Accessibility.CrosSpokenFeedback",
+			IsSpokenFeedbackEnabled());
+  UMA_HISTOGRAM_BOOLEAN("Accessibility.CrosHighContrast",
+			IsHighContrastEnabled());
+  UMA_HISTOGRAM_BOOLEAN("Accessibility.CrosVirtualKeyboard",
+			IsVirtualKeyboardEnabled());
+  UMA_HISTOGRAM_ENUMERATION("Accessibility.CrosScreenMagnifier",
+			    GetScreenMagnifierType(),
+			    3);
+}
+
+void Initialize() {
+  content::BrowserAccessibilityState::GetInstance()->AddHistogramCallback(
+      base::Bind(&UpdateChromeOSAccessibilityHistograms));
+}
+
 void EnableSpokenFeedback(bool enabled, content::WebUI* login_web_ui) {
   bool spoken_feedback_enabled = g_browser_process &&
       g_browser_process->local_state()->GetBoolean(
@@ -245,6 +264,16 @@ bool IsHighContrastEnabled() {
   return high_contrast_enabled;
 }
 
+bool IsVirtualKeyboardEnabled() {
+  if (!g_browser_process) {
+    return false;
+  }
+  PrefService* prefs = g_browser_process->local_state();
+  bool virtual_keyboard_enabled = prefs &&
+      prefs->GetBoolean(prefs::kVirtualKeyboardEnabled);
+  return virtual_keyboard_enabled;
+}
+
 ScreenMagnifierType GetScreenMagnifierType() {
   if (!MagnificationManager::GetInstance())
     return MAGNIFIER_OFF;

[commit-bot: I haz the power, 2012-11-30 20:15:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/11414232/6007

[commit-bot: I haz the power, 2012-11-30 21:33:49]

Retried try job too often on win_aura for step(s) aura_unittests,
content_browsertests, content_unittests, views_unittests

[commit-bot: I haz the power, 2012-11-30 21:37:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/11414232/6007

[commit-bot: I haz the power, 2012-11-30 23:20:58]

Change committed as 170590

[davidjames, 2012-12-01 18:44:57]

It looks like the call to GetMagnifierType() on accessibility_util:124 is
introducing some crashes. Could you take a look and fix or revert?

https://chromiumcodereview.appspot.com/11414232/diff/6007/chrome/browser/chro...
File chrome/browser/chromeos/accessibility/accessibility_util.cc (right):

https://chromiumcodereview.appspot.com/11414232/diff/6007/chrome/browser/chro...
chrome/browser/chromeos/accessibility/accessibility_util.cc:124:
GetMagnifierType(),
It looks like this call to GetMagnifierType() is introducing some crashes. Could
you take a look and fix or revert?

Example crash:
 
https://sandbox.google.com/storage/chromeos-image-archive/amd64-generic-tot-c...

Quoted from that url:

 0  chrome!chromeos::accessibility::GetMagnifierType() [accessibility_util.cc :
283 + 0xb]
    rbx = 0x00007f78513a7f80   r12 = 0x00007f7855cebe80
    r13 = 0x00007f7853e4f648   r14 = 0x00007f784738df30
    r15 = 0x00007f784738ded0   rip = 0x00007f7850535189
    rsp = 0x00007f784738da80   rbp = 0x00007f7855d1e700
    Found by: given as instruction pointer in context
 1  chrome!chromeos::accessibility::UpdateChromeOSAccessibilityHistograms()
[accessibility_util.cc : 124 + 0xc]
    rbx = 0x00007f78513a7f80   r12 = 0x00007f7855cebe80
    r13 = 0x00007f7853e4f648   r14 = 0x00007f784738df30
    r15 = 0x00007f784738ded0   rip = 0x00007f785053526b
    rsp = 0x00007f784738da90   rbp = 0x00007f7855d1e700
    Found by: call frame info
 2  chrome!content::BrowserAccessibilityStateImpl::UpdateHistogram() [callback.h
: 391 + 0x5]
    rbx = 0x0000000000000001   r12 = 0x00007f784738eb00
    r13 = 0x00007f7853e4f648   r14 = 0x00007f784738df30
    r15 = 0x00007f784738ded0   rip = 0x00007f785000e8f4
    rsp = 0x00007f784738dc80   rbp = 0x00007f7855effd80
    Found by: call frame info
 3  chrome!MessageLoop::RunTask(base::PendingTask const&) [callback.h : 391 +
0x6]
    rbx = 0x00007f7853e4f504   r12 = 0x00007f784738eb00
    r13 = 0x00007f7853e4f648   r14 = 0x00007f784738df30
    r15 = 0x00007f784738ded0   rip = 0x00007f785137af36
    rsp = 0x00007f784738de80   rbp = 0x00007f784738e140
    Found by: call frame info

Full logs here:
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28amd6...

[achuithb, 2012-12-03 21:08:36]

I'm getting this DCHECK failure on debug builds:

[30605:30639:1203/130602:FATAL:browser_process_impl.cc(401)] Check failed:
CalledOnValidThread(). 
	base::debug::StackTrace::StackTrace() [0x7ffff562857e]
	logging::LogMessage::~LogMessage() [0x7ffff565d08f]
	BrowserProcessImpl::local_state() [0x23d935f]
	chromeos::accessibility::IsHighContrastEnabled() [0x13d8a34]
	chromeos::accessibility::UpdateChromeOSAccessibilityHistograms() [0x13d7c58]
	base::internal::RunnableAdapter<>::Run() [0x698dcf]
	base::internal::InvokeHelper<>::MakeItSo() [0x698db7]
	base::internal::Invoker<>::Run() [0x698d9d]
	base::Callback<>::Run() [0x7fffecea0c89]
	content::BrowserAccessibilityStateImpl::UpdateHistogram() [0x7fffecea01fe]
	base::internal::RunnableAdapter<>::Run() [0x7fffecea196d]
	base::internal::InvokeHelper<>::MakeItSo() [0x7fffecea1768]
	base::internal::Invoker<>::Run() [0x7fffecea1409]
	base::Callback<>::Run() [0x7ffff561f4ad]
	MessageLoop::RunTask() [0x7ffff5663355]
	MessageLoop::DeferOrRunPendingTask() [0x7ffff5663470]
	MessageLoop::DoDelayedWork() [0x7ffff5663f1b]
	base::MessagePumpLibevent::Run() [0x7ffff56081a8]
	MessageLoop::RunInternal() [0x7ffff5662f45]
	MessageLoop::RunHandler() [0x7ffff5662dfc]
	base::RunLoop::Run() [0x7ffff569aed2]
	MessageLoop::Run() [0x7ffff566272a]
	base::Thread::Run() [0x7ffff56dc840]
	content::BrowserThreadImpl::FileThreadRun() [0x7fffecec2ba3]
	content::BrowserThreadImpl::Run() [0x7fffecec2f64]
	base::Thread::ThreadMain() [0x7ffff56dc9cb]
	base::(anonymous namespace)::ThreadFunc() [0x7ffff56cea57]
	start_thread [0x7fffea7c19ca]
	<unknown> [0x7fffe759d21d]


Program received signal SIGTRAP, Trace/breakpoint trap.
base::debug::BreakDebugger () at ../../base/debug/debugger_posix.cc:256
256	}

[dmazzoni, 2012-12-03 23:41:13]

Fixing DCHECK failure with:
https://codereview.chromium.org/11299312/

On 2012/12/03 21:08:36, achuith.bhandarkar wrote:
> I'm getting this DCHECK failure on debug builds:
> 
> [30605:30639:1203/130602:FATAL:browser_process_impl.cc(401)] Check failed:
> CalledOnValidThread(). 
> 	base::debug::StackTrace::StackTrace() [0x7ffff562857e]
> 	logging::LogMessage::~LogMessage() [0x7ffff565d08f]
> 	BrowserProcessImpl::local_state() [0x23d935f]
> 	chromeos::accessibility::IsHighContrastEnabled() [0x13d8a34]
> 	chromeos::accessibility::UpdateChromeOSAccessibilityHistograms() [0x13d7c58]
> 	base::internal::RunnableAdapter<>::Run() [0x698dcf]
> 	base::internal::InvokeHelper<>::MakeItSo() [0x698db7]
> 	base::internal::Invoker<>::Run() [0x698d9d]
> 	base::Callback<>::Run() [0x7fffecea0c89]
> 	content::BrowserAccessibilityStateImpl::UpdateHistogram() [0x7fffecea01fe]
> 	base::internal::RunnableAdapter<>::Run() [0x7fffecea196d]
> 	base::internal::InvokeHelper<>::MakeItSo() [0x7fffecea1768]
> 	base::internal::Invoker<>::Run() [0x7fffecea1409]
> 	base::Callback<>::Run() [0x7ffff561f4ad]
> 	MessageLoop::RunTask() [0x7ffff5663355]
> 	MessageLoop::DeferOrRunPendingTask() [0x7ffff5663470]
> 	MessageLoop::DoDelayedWork() [0x7ffff5663f1b]
> 	base::MessagePumpLibevent::Run() [0x7ffff56081a8]
> 	MessageLoop::RunInternal() [0x7ffff5662f45]
> 	MessageLoop::RunHandler() [0x7ffff5662dfc]
> 	base::RunLoop::Run() [0x7ffff569aed2]
> 	MessageLoop::Run() [0x7ffff566272a]
> 	base::Thread::Run() [0x7ffff56dc840]
> 	content::BrowserThreadImpl::FileThreadRun() [0x7fffecec2ba3]
> 	content::BrowserThreadImpl::Run() [0x7fffecec2f64]
> 	base::Thread::ThreadMain() [0x7ffff56dc9cb]
> 	base::(anonymous namespace)::ThreadFunc() [0x7ffff56cea57]
> 	start_thread [0x7fffea7c19ca]
> 	<unknown> [0x7fffe759d21d]
> 
> 
> Program received signal SIGTRAP, Trace/breakpoint trap.
> base::debug::BreakDebugger () at ../../base/debug/debugger_posix.cc:256
> 256	}