chrome/common/extensions/api/declarative_web_request.json - Issue 11414230: Declarative Web Request: firstPartyForCookiesUrl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/declarative_web_request.json

Issue 11414230: Declarative Web Request: firstPartyForCookiesUrl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Jeffrey's comments addressed Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_request/web_request_api.cc ('k') | chrome/test/data/extensions/api_test/webrequest/test_declarative.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/declarative_web_request.json

diff --git a/chrome/common/extensions/api/declarative_web_request.json b/chrome/common/extensions/api/declarative_web_request.json

index 2d781a95ff3baa3b9cb4cf046fea24d83c93cbfd..f1fd555216fa7abec071f2768eceb79206e3494b 100644

--- a/chrome/common/extensions/api/declarative_web_request.json

+++ b/chrome/common/extensions/api/declarative_web_request.json

@@ -67,7 +67,12 @@

"properties": {

"url": {

"$ref": "events.UrlFilter",

- "description": "Matches if the condition of the UrlFilter are fulfilled for the URL of the request.",

+ "description": "Matches if the conditions of the UrlFilter are fulfilled for the URL of the request.",

+ "optional": true

+ },

+ "firstPartyForCookiesUrl": {

+ "$ref": "events.UrlFilter",

+ "description": "Each URL request can be assigned a special URL, different from the request's target URL. The special URL describes what is considered 'first party' for the sake of third-party checks for cookies. This attribute allows to match against the special URL.",

Yoyo Zhou 2013/01/24 21:29:43 This should have the form "Matches..." so perhaps

vabr (Chromium) 2013/01/25 06:37:40 Rephrased. Better now?

"optional": true

"resourceType": {