Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1320)

Unified Diff: chrome/browser/extensions/api/declarative/declarative_rule_unittest.cc

Issue 11414230: Declarative Web Request: firstPartyForCookiesUrl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Back to one matcher Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/declarative/declarative_rule_unittest.cc
diff --git a/chrome/browser/extensions/api/declarative/declarative_rule_unittest.cc b/chrome/browser/extensions/api/declarative/declarative_rule_unittest.cc
index 5cadb74588932395790706defd11a7cd6258a4d3..2ca56579e90c4c41ec6f04637b35f8320935b66b 100644
--- a/chrome/browser/extensions/api/declarative/declarative_rule_unittest.cc
+++ b/chrome/browser/extensions/api/declarative/declarative_rule_unittest.cc
@@ -35,10 +35,6 @@ struct RecordingCondition {
// No condition sets.
}
- bool has_url_matcher_condition_set() const {
- return false;
- }
-
static scoped_ptr<RecordingCondition> Create(
URLMatcherConditionFactory* url_matcher_condition_factory,
const base::Value& condition,
@@ -102,10 +98,6 @@ struct FulfillableCondition {
return condition_set_id;
}
- bool has_url_matcher_condition_set() const {
- return true;
- }
-
scoped_refptr<URLMatcherConditionSet> url_matcher_condition_set() const {
return condition_set;
}
@@ -124,7 +116,7 @@ struct FulfillableCondition {
}
static scoped_ptr<FulfillableCondition> Create(
- URLMatcherConditionFactory* url_matcher_condition_factory,
+ URLMatcherConditionFactory* /*url_matcher_condition_factory*/,
const base::Value& condition,
std::string* error) {
scoped_ptr<FulfillableCondition> result(new FulfillableCondition());

Powered by Google App Engine
This is Rietveld 408576698