Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc

Issue 11414230: Declarative Web Request: firstPartyForCookiesUrl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased + attribute description in JSON changed Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc
diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc b/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc
index e6a26ea5abe2ee80a3b8db5ff04ae63977f073af..a25c1f6b3ab4b2ae84afa0d0e03849bb51e13fd9 100644
--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc
+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc
@@ -139,7 +139,7 @@ TEST(WebRequestActionTest, TestPermissions) {
// Check that redirect works on regular URLs but not on protected URLs.
net::TestURLRequest regular_request(GURL("http://test.com"), NULL, &context);
std::list<LinkedPtrEventResponseDelta> deltas;
- DeclarativeWebRequestData request_data(&regular_request, ON_BEFORE_REQUEST);
+ WebRequestData request_data(&regular_request, ON_BEFORE_REQUEST);
WebRequestAction::ApplyInfo apply_info = {
NULL, request_data, false, &deltas
};
@@ -149,8 +149,8 @@ TEST(WebRequestActionTest, TestPermissions) {
net::TestURLRequest protected_request(GURL("http://clients1.google.com"),
NULL, &context);
deltas.clear();
- request_data =
- DeclarativeWebRequestData(&protected_request, ON_BEFORE_REQUEST);
+ request_data = WebRequestData(&protected_request, ON_BEFORE_REQUEST);
+ // Note that we just updated the request_data reference in apply_info.
action_set->Apply("ext1", base::Time(), &apply_info);
EXPECT_EQ(0u, deltas.size());
}

Powered by Google App Engine
This is Rietveld 408576698