Declarative Web Request: firstPartyForCookiesUrl

chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_DECLARATIVE_WEBREQUEST_WEBREQUEST_RULES_REGISTRY_H_
 #define CHROME_BROWSER_EXTENSIONS_API_DECLARATIVE_WEBREQUEST_WEBREQUEST_RULES_REGISTRY_H_
 
 #include <list>
 #include <map>
 #include <set>
@@ skipping 57 matching lines @@
 // "http://www.example.com/query/" has any matches, and the URLMatcher
 // will respond with the URLMatcherConditionSet::ID. We can map this
 // to the WebRequestRule and check whether also the other conditions (in this
 // example 'scheme': 'http') are fulfilled.
 class WebRequestRulesRegistry : public RulesRegistryWithCache {
  public:
   WebRequestRulesRegistry(Profile* profile, Delegate* delegate);
 
   // TODO(battre): This will become an implementation detail, because we need
   // a way to also execute the actions of the rules.
   std::set<const WebRequestRule*> GetMatches(

[Jeffrey Yasskin, 2013/01/24 00:39:17]

Dominic told me to make ContentRulesRegistery::GetMatches const. Of course, no
need to do that for WebRequest in this change.

[vabr (Chromium), 2013/01/24 18:24:08]

Yay, hooray to const URLMatcher::MatchURL()! :)
Done.

-      const DeclarativeWebRequestData& request_data);
+      DeclarativeWebRequestData* request_data);
 
   // Returns which modifications should be executed on the network request
   // according to the rules registered in this registry.
   std::list<LinkedPtrEventResponseDelta> CreateDeltas(
       const ExtensionInfoMap* extension_info_map,
-      const DeclarativeWebRequestData& request_data,
+      DeclarativeWebRequestData* request_data,
       bool crosses_incognito);
 
   // Implementation of RulesRegistryWithCache:
   virtual std::string AddRulesImpl(
       const std::string& extension_id,
       const std::vector<linked_ptr<RulesRegistry::Rule> >& rules) OVERRIDE;
   virtual std::string RemoveRulesImpl(
       const std::string& extension_id,
       const std::vector<std::string>& rule_identifiers) OVERRIDE;
   virtual std::string RemoveAllRulesImpl(
@@ skipping 21 matching lines @@
   // meaning for example that we do not allow combining an |action| that needs
   // to be executed before the |condition| can be fulfilled.
   // Returns true in case of consistency and MUST set |error| otherwise.
   static bool CheckConsistency(const WebRequestConditionSet* conditions,
                                const WebRequestActionSet* actions,
                                std::string* error);
 
   typedef std::map<URLMatcherConditionSet::ID, WebRequestRule*> RuleTriggers;
   typedef std::map<WebRequestRule::GlobalRuleId, linked_ptr<WebRequestRule> >
       RulesMap;
+  typedef std::set<URLMatcherConditionSet::ID> URLMatches;
+  typedef std::set<const WebRequestRule*> RuleSet;
+
+  // This is a helper function to GetMatches. Rules triggered by |url_matches|
+  // get added to |result| if one of their conditions fires. |request_data| get

[Jeffrey Yasskin, 2013/01/24 00:39:17]

s/fires/is fulfilled/?

[vabr (Chromium), 2013/01/24 18:24:08]

Done.

+  // just passed to IsFulfilled of the rules' condition sets.
+  void AddTriggeredRules(const URLMatches& url_matches,
+                         const DeclarativeWebRequestData& request_data,
+                         RuleSet* result);
 
   // Map that tells us which WebRequestRule may match under the condition that
   // the URLMatcherConditionSet::ID was returned by the |url_matcher_|.
   RuleTriggers rule_triggers_;
 
   // These rules contain condition sets with conditions without URL attributes.
   // Such conditions are not triggered by URL matcher, so we need to test them
   // separately.
   std::set<const WebRequestRule*> rules_with_untriggered_conditions_;
 
   RulesMap webrequest_rules_;
 
   URLMatcher url_matcher_;
 
   scoped_refptr<ExtensionInfoMap> extension_info_map_;
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_DECLARATIVE_WEBREQUEST_WEBREQUEST_RULES_REGISTRY_H_