Declarative Web Request: firstPartyForCookiesUrl

chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.h"
 
 #include <set>
 
 #include "base/message_loop.h"
 #include "base/test/values_test_util.h"
@@ skipping 10 matching lines @@
 namespace keys2 = url_matcher_constants;
 
 TEST(WebRequestConditionTest, CreateCondition) {
   // Necessary for TestURLRequest.
   MessageLoop message_loop(MessageLoop::TYPE_IO);
   URLMatcher matcher;
 
   std::string error;
   scoped_ptr<WebRequestCondition> result;
 
-
   // Test wrong condition name passed.
   error.clear();
   result = WebRequestCondition::Create(
       matcher.condition_factory(),
       *base::test::ParseJson(
           "{ \"invalid\": \"foobar\", \n"
           "  \"instanceType\": \"declarativeWebRequest.RequestMatcher\", \n"
           "}"),
       &error);
   EXPECT_FALSE(error.empty());
@@ skipping 13 matching lines @@
   EXPECT_FALSE(result.get());
 
   // Test success (can we support multiple criteria?)
   error.clear();
   result = WebRequestCondition::Create(
       matcher.condition_factory(),
       *base::test::ParseJson(
           "{ \n"
           "  \"resourceType\": [\"main_frame\"], \n"
           "  \"url\": { \"hostSuffix\": \"example.com\" }, \n"
+          "  \"firstPartyForCookiesUrl\": { \"hostPrefix\": \"fpfc\"}, \n"

[Jeffrey Yasskin, 2013/01/24 00:39:17]

Instead of extending this test, I'd add a separate TEST() for
firstPartyForCookiesUrl. That way there's no worry that this CL changes the
behavior of the existing code, and future test failures point more precisely to
a particular attribute type.

[vabr (Chromium), 2013/01/24 18:24:08]

Done.

           "  \"instanceType\": \"declarativeWebRequest.RequestMatcher\", \n"
           "}"),
       &error);
   EXPECT_EQ("", error);
   ASSERT_TRUE(result.get());
 
   URLMatcherConditionSet::Vector url_matcher_condition_set;
   result->GetURLMatcherConditionSets(&url_matcher_condition_set);
   matcher.AddConditionSets(url_matcher_condition_set);
-  std::set<URLMatcherConditionSet::ID> url_match_ids;
 
   net::TestURLRequestContext context;
   GURL http_url("http://www.example.com");
+  GURL first_party_url("http://fpfc.example.com");
   net::TestURLRequest match_request(http_url, NULL, &context);
-  url_match_ids = matcher.MatchURL(http_url);
-  EXPECT_EQ(1u, url_match_ids.size());
+  DeclarativeWebRequestData request_data(&match_request, ON_BEFORE_REQUEST);
+  request_data.url_match_ids = matcher.MatchURL(http_url);
+  EXPECT_EQ(1u, request_data.url_match_ids.size());
+  request_data.first_party_url_match_ids = matcher.MatchURL(first_party_url);
+  EXPECT_EQ(1u, request_data.url_match_ids.size());
   content::ResourceRequestInfo::AllocateForTesting(&match_request,
       ResourceType::MAIN_FRAME, NULL, -1, -1);
-  EXPECT_TRUE(result->IsFulfilled(
-      url_match_ids,
-      DeclarativeWebRequestData(&match_request, ON_BEFORE_REQUEST)));
+  EXPECT_TRUE(result->IsFulfilled(request_data));
 
   GURL https_url("https://www.example.com");
   net::TestURLRequest wrong_resource_type(https_url, NULL, &context);
-  url_match_ids = matcher.MatchURL(https_url);
+  request_data.request = &wrong_resource_type;
+  request_data.url_match_ids = matcher.MatchURL(http_url);
   // Make sure IsFulfilled does not fail because of URL matching.
-  EXPECT_EQ(1u, url_match_ids.size());
+  EXPECT_EQ(1u, request_data.url_match_ids.size());
   content::ResourceRequestInfo::AllocateForTesting(&wrong_resource_type,
       ResourceType::SUB_FRAME, NULL, -1, -1);
-  EXPECT_FALSE(result->IsFulfilled(
-      url_match_ids,
-      DeclarativeWebRequestData(&wrong_resource_type, ON_BEFORE_REQUEST)));
+  EXPECT_FALSE(result->IsFulfilled(request_data));
 }
 
 // Conditions without UrlFilter attributes need to be independent of URL
 // matching results. We test here that:
 //   1. A non-empty condition without UrlFilter attributes is fulfilled iff its
 //      attributes are fulfilled.
 //   2. An empty condition (in particular, without UrlFilter attributes) is
 //      always fulfilled.
 TEST(WebRequestConditionTest, NoUrlAttributes) {
   // Necessary for TestURLRequest.
@@ skipping 39 matching lines @@
               "  \"instanceType\": \"declarativeWebRequest.RequestMatcher\", \n"
               "  \"thirdPartyForCookies\": true, \n"
               "}"),
           &error);
   EXPECT_EQ("", error);
   ASSERT_TRUE(condition_no_url_false.get());
 
   net::TestURLRequestContext context;
   net::TestURLRequest https_request(
       GURL("https://www.example.com"), NULL, &context);
-  std::set<URLMatcherConditionSet::ID> dummy_match_set;
 
   // 1. A non-empty condition without UrlFilter attributes is fulfilled iff its
   //    attributes are fulfilled.
   EXPECT_FALSE(condition_no_url_false->IsFulfilled(
-      dummy_match_set,
       DeclarativeWebRequestData(&https_request, ON_BEFORE_REQUEST)));
 
   EXPECT_TRUE(condition_no_url_true->IsFulfilled(
-      dummy_match_set,
       DeclarativeWebRequestData(&https_request, ON_BEFORE_REQUEST)));
 
   // 2. An empty condition (in particular, without UrlFilter attributes) is
   //    always fulfilled.
   EXPECT_TRUE(condition_empty->IsFulfilled(
-      dummy_match_set,
       DeclarativeWebRequestData(&https_request, ON_BEFORE_REQUEST)));
 }
 
 TEST(WebRequestConditionTest, CreateConditionSet) {

[Jeffrey Yasskin, 2013/01/24 00:39:17]

Consider removing this test entirely, although not necessarily in this change.
It should be covered by declarative_rule_unittest.

[vabr (Chromium), 2013/01/24 18:24:08]

I don't think removing this test should be done in this CL, it has not much to
do with the rest.

Dominic, do you want me to remove this in a separate CL, or do you want to keep
that test?

It's true that the condition set's creation code is covered in
declarative_rule_unittest, and the condition's creation code in the first test
here.

   // Necessary for TestURLRequest.
   MessageLoop message_loop(MessageLoop::TYPE_IO);
   URLMatcher matcher;
 
   WebRequestConditionSet::AnyVector conditions;
   conditions.push_back(linked_ptr<base::Value>(base::test::ParseJson(
       "{ \n"
       "  \"instanceType\": \"declarativeWebRequest.RequestMatcher\", \n"
       "  \"url\": { \n"
       "    \"hostSuffix\": \"example.com\", \n"
@@ skipping 17 matching lines @@
                                      conditions, &error);
   EXPECT_EQ("", error);
   ASSERT_TRUE(result.get());
   EXPECT_EQ(2u, result->conditions().size());
 
   // Tell the URLMatcher about our shiny new patterns.
   URLMatcherConditionSet::Vector url_matcher_condition_set;
   result->GetURLMatcherConditionSets(&url_matcher_condition_set);
   matcher.AddConditionSets(url_matcher_condition_set);
 
-  std::set<URLMatcherConditionSet::ID> url_match_ids;
-
   // Test that the result is correct and matches http://www.example.com and
   // https://www.example.com
   GURL http_url("http://www.example.com");
   net::TestURLRequestContext context;
   net::TestURLRequest http_request(http_url, NULL, &context);
-  url_match_ids = matcher.MatchURL(http_url);
-  EXPECT_EQ(1u, url_match_ids.size());
-  EXPECT_TRUE(result->IsFulfilled(
-      *(url_match_ids.begin()),
-      url_match_ids,
-      DeclarativeWebRequestData(&http_request, ON_BEFORE_REQUEST)));
+  DeclarativeWebRequestData request_data(&http_request, ON_BEFORE_REQUEST);
+  request_data.url_match_ids = matcher.MatchURL(http_url);
+  EXPECT_EQ(1u, request_data.url_match_ids.size());
+  EXPECT_TRUE(result->IsFulfilled(*(request_data.url_match_ids.begin()),
+                                  request_data));
 
   GURL https_url("https://www.example.com");
-  url_match_ids = matcher.MatchURL(https_url);
-  EXPECT_EQ(1u, url_match_ids.size());
+  request_data.url_match_ids = matcher.MatchURL(https_url);
+  EXPECT_EQ(1u, request_data.url_match_ids.size());
   net::TestURLRequest https_request(https_url, NULL, &context);
-  EXPECT_TRUE(result->IsFulfilled(
-      *(url_match_ids.begin()),
-      url_match_ids,
-      DeclarativeWebRequestData(&https_request, ON_BEFORE_REQUEST)));
+  request_data.request = &https_request;
+  EXPECT_TRUE(result->IsFulfilled(*(request_data.url_match_ids.begin()),
+                                  request_data));
 
   // Check that both, hostPrefix and hostSuffix are evaluated.
   GURL https_foo_url("https://foo.example.com");
-  url_match_ids = matcher.MatchURL(https_foo_url);
-  EXPECT_EQ(0u, url_match_ids.size());
+  request_data.url_match_ids = matcher.MatchURL(https_foo_url);
+  EXPECT_EQ(0u, request_data.url_match_ids.size());
   net::TestURLRequest https_foo_request(https_foo_url, NULL, &context);
-  EXPECT_FALSE(result->IsFulfilled(
-      -1,
-      url_match_ids,
-      DeclarativeWebRequestData(&https_foo_request, ON_BEFORE_REQUEST)));
+  request_data.request = &https_foo_request;
+  EXPECT_FALSE(result->IsFulfilled(-1, request_data));
 }
 
 TEST(WebRequestConditionTest, TestPortFilter) {
   // Necessary for TestURLRequest.
   MessageLoop message_loop(MessageLoop::TYPE_IO);
   URLMatcher matcher;
 
   WebRequestConditionSet::AnyVector conditions;
   conditions.push_back(linked_ptr<base::Value>(base::test::ParseJson(
       "{ \n"
@@ skipping 47 matching lines @@
 // the response header. The Create() method should fail and complain that it is
 // impossible that both conditions are fulfilled at the same time.
 TEST(WebRequestConditionTest, ConditionsWithConflictingStages) {
   // Necessary for TestURLRequest.
   MessageLoop message_loop(MessageLoop::TYPE_IO);
   URLMatcher matcher;
 
   std::string error;
   scoped_ptr<WebRequestCondition> result;
 
-  DictionaryValue condition_value;
-  condition_value.SetString(keys::kInstanceTypeKey, keys::kRequestMatcherType);
-
-
   // Test error on incompatible application stages for involved attributes.
   error.clear();
   result = WebRequestCondition::Create(
       matcher.condition_factory(),
       *base::test::ParseJson(
           "{ \n"
           "  \"instanceType\": \"declarativeWebRequest.RequestMatcher\", \n"
           // Pass a JS array with one empty object to each of the header
           // filters.
           "  \"requestHeaders\": [{}], \n"
           "  \"responseHeaders\": [{}], \n"
           "}"),
       &error);
   EXPECT_FALSE(error.empty());
   EXPECT_FALSE(result.get());
 }
 
 }  // namespace extensions