Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11414226: Encrypted Media: Support natural size in video decrypt-and-decode path. (Closed)

Created:
8 years ago by xhwang
Modified:
8 years ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Encrypted Media: Support natural size in video decrypt-and-decode path. BUG=163755 TEST=EncryptedMediaTest.FrameChangeVideo in content_browsertests using externalclearkey. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170995

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : resolve comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M webkit/plugins/ppapi/content_decryptor_delegate.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/content_decryptor_delegate.cc View 1 5 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
xhwang
PTAL!
8 years ago (2012-12-01 04:29:26 UTC) #1
ddorwin
Seems fine. I'll defer to scherkus for correctness. Does this CL really do anything for ...
8 years ago (2012-12-01 04:44:41 UTC) #2
xhwang
https://codereview.chromium.org/11414226/diff/2001/webkit/plugins/ppapi/content_decryptor_delegate.h File webkit/plugins/ppapi/content_decryptor_delegate.h (right): https://codereview.chromium.org/11414226/diff/2001/webkit/plugins/ppapi/content_decryptor_delegate.h#newcode18 webkit/plugins/ppapi/content_decryptor_delegate.h:18: #include "ui/gfx/size.h" On 2012/12/01 04:44:41, ddorwin wrote: > We ...
8 years ago (2012-12-01 05:38:43 UTC) #3
scherkus (not reviewing)
lgtm
8 years ago (2012-12-03 18:31:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/11414226/5004
8 years ago (2012-12-03 21:45:03 UTC) #5
commit-bot: I haz the power
Presubmit check for 11414226-5004 failed and returned exit status 1. Running presubmit commit checks ...
8 years ago (2012-12-03 21:45:09 UTC) #6
xhwang
dmichael: please do an OWNERS review! Thanks!
8 years ago (2012-12-03 21:47:52 UTC) #7
dmichael (off chromium)
lgtm
8 years ago (2012-12-03 22:37:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/11414226/5004
8 years ago (2012-12-03 22:56:33 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-04 01:04:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/11414226/5004
8 years ago (2012-12-04 01:06:34 UTC) #11
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests
8 years ago (2012-12-04 04:18:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/11414226/5004
8 years ago (2012-12-04 04:22:15 UTC) #13
commit-bot: I haz the power
8 years ago (2012-12-04 06:25:21 UTC) #14 
Retried try job too often on mac_rel for step(s) browser_tests

Powered by Google App Engine
This is Rietveld 408576698