Expose transferable constructor to Int8List

runtime/vm/os.h

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_OS_H_
 #define VM_OS_H_
 
 #include "vm/globals.h"
 
 // Forward declarations.
@@ skipping 22 matching lines @@
   static int GetLocalTimeZoneAdjustmentInSeconds();
 
   // Returns the current time in milliseconds measured
   // from midnight January 1, 1970 UTC.
   static int64_t GetCurrentTimeMillis();
 
   // Returns the current time in microseconds measured
   // from midnight January 1, 1970 UTC.
   static int64_t GetCurrentTimeMicros();
 
+  // Returns an aligned array of type T with n entries.
+  // Alignment must be >= 16 and a power of two.
+  template<typename T>

[cshapiro, 2012/11/30 18:56:53]

If you are going to live with the NOLINT why not just

template<typename T>
static T* AllocateAlignedArray(intptr_t n, intptr_t alignment) {
  intptr_t size = n * sizeof(T);  // NOLINT
  return reinterpret_cast<T*>(OS::AlignedAllocate(size, alignment));
}

or avoid it

template<typename T>
static T* AllocateAlignedArray(intptr_t n, intptr_t alignment) {
  T* result = reinterpret_cast<T*>(OS::AlignedAllocate(n * sizeof(*result),
                                                       alignment));
  return result;
}

Either way, please add spaces around *

[Cutch, 2012/11/30 19:27:10]

Done.

+  static T* AllocateAlignedArray(intptr_t n, intptr_t alignment) {
+    intptr_t size = n*sizeof(T);  // NOLINT
+    void* p = OS::AlignedAllocate(size, alignment);
+    return reinterpret_cast<T*>(p);
+  }
+
+  // Returns an aligned pointer in the C heap with room for size bytes.
+  // Alignment must be >= 16 and a power of two.
+  static void* AlignedAllocate(intptr_t size, intptr_t alignment);
+
+  // Frees a pointer returned from AlignedAllocate.
+  static void AlignedFree(void* ptr);
+
   // Returns the activation frame alignment constraint or zero if
   // the platform doesn't care. Guaranteed to be a power of two.
   static word ActivationFrameAlignment();
 
   // This constant is guaranteed to be greater or equal to the
   // preferred code alignment on all platforms.
   static const int kMaxPreferredCodeAlignment = 32;
 
   // Returns the preferred code alignment or zero if
   // the platform doesn't care. Guaranteed to be a power of two.
@@ skipping 49 matching lines @@
   static void Shutdown();
 
   static void Abort();
 
   static void Exit(int code);
 };
 
 }  // namespace dart
 
 #endif  // VM_OS_H_