Delay scroll to section until page initialization is complete.

chrome/browser/resources/options/browser_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
   var ArrayDataModel = cr.ui.ArrayDataModel;
   var RepeatingButton = cr.ui.RepeatingButton;
 
   //
@@ skipping 14 matching lines @@
     syncSetupCompleted: false,
 
     /**
      * Keeps track of whether |onShowHomeButtonChanged_| has been called. See
      * |onShowHomeButtonChanged_|.
      * @type {bool}
      * @private
      */
     onShowHomeButtonChangedCalled_: false,
 
+    /**
+     * Track if page initialization is complete.  All C++ UI handlers have the
+     * chance to manipulate page content within their InitializePage mathods.
+     * This flag is set to true after all initializers have been called.
+     * @type (boolean}
+     * @private
+     */
+    initializationComplete_: false,
+
     /** @override */
     initializePage: function() {
       OptionsPage.prototype.initializePage.call(this);
       var self = this;
 
+      this.initializationComplete_ = false;

[James Hawkins, 2012/11/29 23:20:21]

Why do we need to set this here?  Does reinitialization happen?

[kevers, 2012/11/30 19:46:25]

Flag reset is redundant.  Removed.

+
       // Ensure that navigation events are unblocked on uber page. A reload of
       // the settings page while an overlay is open would otherwise leave uber
       // page in a blocked state, where tab switching is not possible.
       uber.invokeMethodOnParent('stopInterceptingEvents');
 
       window.addEventListener('message', this.handleWindowMessage_.bind(this));
 
       $('advanced-settings-expander').onclick = function() {
         self.toggleSectionWithAnimation_(
             $('advanced-settings'),
@@ skipping 361 matching lines @@
           OptionsPage.navigateToPage('factoryResetData');
         };
       }
     },
 
     /** @override */
     didShowPage: function() {
       $('search-field').focus();
     },
 
+   /**
+    * Called after all C++ UI handlers have called InitializePage to notify
+    * that initialization is complete.
+    * @private
+    */
+    notifyInitializationComplete_: function() {
+      this.initializationComplete_ = true;
+      cr.dispatchSimpleEvent(document, 'initializationComplete');
+    },
+
     /**
      * Event listener for the 'session.restore_on_startup' pref.
      * @param {Event} event The preference change event.
      * @private
      */
     onRestoreOnStartupChanged_: function(event) {
       /** @const */ var showHomePageValue = 0;
 
       if (event.value.value == showHomePageValue) {
         // If the user previously selected "Show the homepage", the
@@ skipping 108 matching lines @@
      */
     scrollToSection_: function(section) {
       var advancedSettings = $('advanced-settings');
       var container = $('advanced-settings-container');
       if (advancedSettings.hidden && section.parentNode == container) {
         this.showSection_($('advanced-settings'),
                           $('advanced-settings-container'),
                           /* animate */ false);
         this.updateAdvancedSettingsExpander_();
       }
+
+      if (!this.initializationComplete_) {
+        var self = this;
+        var callback = function() {
+           document.removeEventListener('initializationComplete', callback);
+           self.scrollToSection_(section);
+        };
+        document.addEventListener('initializationComplete', callback);
+        return;
+      }
+
       var pageContainer = $('page-container');
       var pageTop = parseFloat(pageContainer.style.top);
       var topSection = document.querySelector('#page-container section');
       var pageHeight = document.body.scrollHeight - topSection.offsetTop;
       var sectionTop = section.offsetTop;
       var sectionHeight = section.offsetHeight;
       var marginBottom = window.getComputedStyle(section).marginBottom;
       if (marginBottom)
         sectionHeight += parseFloat(marginBottom);
       if (pageHeight - pageTop < sectionTop + sectionHeight) {
@@ skipping 720 matching lines @@
 
   };
 
   //Forward public APIs to private implementations.
   [
     'addBluetoothDevice',
     'enableFactoryResetSection',
     'getCurrentProfile',
     'getStartStopSyncButton',
     'hideBluetoothSettings',
+    'notifyInitializationComplete',
     'removeBluetoothDevice',
     'removeCloudPrintConnectorSection',
     'scrollToSection',
     'setAutoOpenFileTypesDisplayed',
     'setBluetoothState',
     'setFontSize',
     'setGtkThemeButtonEnabled',
     'setHighContrastCheckboxState',
     'setMetricsReportingCheckboxState',
     'setMetricsReportingSettingVisibility',
@@ skipping 32 matching lines @@
     BrowserOptions.getLoggedInUsername = function() {
       return BrowserOptions.getInstance().username_;
     };
   }
 
   // Export
   return {
     BrowserOptions: BrowserOptions
   };
 });