test/mjsunit/harmony/object-observe.js - Issue 11414177: When notifying observers of a truncated array, don't call getters on deleted element indices

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/mjsunit/harmony/object-observe.js

Issue 11414177: When notifying observers of a truncated array, don't call getters on deleted element indices (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/mjsunit/harmony/object-observe.js

diff --git a/test/mjsunit/harmony/object-observe.js b/test/mjsunit/harmony/object-observe.js

index 474bfcd3bc49bb7aeb8f7a8d92e97f725161ca5d..d88c24eac5bcd87c98ecf0e7b6899ada76c0e050 100644

--- a/test/mjsunit/harmony/object-observe.js

+++ b/test/mjsunit/harmony/object-observe.js

@@ -584,8 +584,7 @@ Object.defineProperty(arr3, 'length', {value: 10, writable: false});

Object.deliverChangeRecords(observer.callback);

observer.assertCallbackRecords([

{ object: arr, name: '3', type: 'deleted', oldValue: 'd' },

- // TODO(adamk): oldValue should not be present below

- { object: arr, name: '2', type: 'deleted', oldValue: undefined },

+ { object: arr, name: '2', type: 'deleted' },

{ object: arr, name: 'length', type: 'updated', oldValue: 4 },

{ object: arr, name: '1', type: 'deleted', oldValue: 'b' },

{ object: arr, name: 'length', type: 'updated', oldValue: 2 },

« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »