tests/try_job_on_rietveld_test.py - Issue 11414143: Change models.py to use typed class members instead of a list of strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/try_job_on_rietveld_test.py

Issue 11414143: Change models.py to use typed class members instead of a list of strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/commit-queue

Patch Set: Address review comments Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/try_job_on_rietveld_test.py

diff --git a/tests/try_job_on_rietveld_test.py b/tests/try_job_on_rietveld_test.py

index 563eff072c1d46b3b4f2f5d54d33be2096c929c8..df3066fbb449f5dff531ccc79b77c7037c43d083 100755

--- a/tests/try_job_on_rietveld_test.py

+++ b/tests/try_job_on_rietveld_test.py

@@ -77,7 +77,6 @@ def _posted(builders):

def gen_job_pending(**kwargs):

value = {

- '__persistent_module__': 'verification.try_job_on_rietveld',

'__persistent_type__': 'RietveldTryJobPending',

'builder': None,

'clobber': False,

@@ -92,7 +91,6 @@ def gen_job_pending(**kwargs):

def gen_job(**kwargs):

value = {

- '__persistent_module__': 'verification.try_job_on_rietveld',

'__persistent_type__': 'RietveldTryJob',

'build': None,

'builder': None,

@@ -114,7 +112,6 @@ def gen_job(**kwargs):

def gen_jobs(**kwargs):

value = {

- '__persistent_module__': 'verification.try_job_on_rietveld',

'__persistent_type__': 'RietveldTryJobs',

'builders_and_tests': {},

'triggered_builders': {},

« no previous file with comments | « tests/pending_manager_test.py ('k') | verification/base.py » ('j') | no next file with comments »