Change models.py to use typed class members instead of a list of strings.

verification/try_server.py

 # coding=utf8
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Sends patches to the Try server and reads back results.
 
 - TryJobs contains TryJob, one per try job on a builder.
 - TryRunnerBase contains the common logic to send try jobs and responds to the
   try job results.
 - TryRunnerSvn uses svn plus /json polling on the try server for status updates.
@@ skipping 54 matching lines @@
 
 
 class TryJob(model.PersistentMixIn):
   """Represents a try job for a pending commit.
 
   This data can be regenerated by parsing all the try job names but it is a bit
   hard on the try server.
 
   TODO(maruel): Should use __getstate__(), __setstate__() and __reduce__().
   """
-  persistent = [
-      'builder', 'build', 'revision', 'result', 'sent', 'failed_steps',
-      'clobber', 'name', 'tries', 'tests',
-  ]
+  builder = str
+  build = int
+  revision = (None, int)
+  result = (None, int)
+  sent = int
+  failed_steps = list
+  clobber = bool
+  name = (None, str)
+  # Number of retries for this configuration.
+  tries = int
+  tests = list
 
-  def __init__(self, builder, tests, revision, clobber):
-    super(TryJob, self).__init__()
-    self.builder = builder
-    self.build = None
-    self.revision = revision
-    self.result = None
-    self.sent = time.time()
-    self.failed_steps = []
-    self.clobber = clobber
-    self.name = None
-    # Number of retries for this configuration.
-    self.tries = 0
-    self.tests = tests
+  def __init__(self, **kwargs):
+    super(TryJob, self).__init__(sent=time.time(), **kwargs)
 
   def get_state(self):
     if self.result in (
         buildbot_json.SUCCESS, buildbot_json.WARNINGS, buildbot_json.SKIPPED):
       return base.SUCCEEDED
     elif self.result in (
         buildbot_json.FAILURE, buildbot_json.EXCEPTION, buildbot_json.RETRY):
       return base.FAILED
     else:
       assert self.result == None
       return base.PROCESSING
 
 
 class TryJobs(base.IVerifierStatus):
   """A set of try jobs that were sent for a specific patch."""
-  persistent = base.IVerifierStatus.persistent + [
-      'try_jobs', 'skipped'
-  ]
-
-  def __init__(self):
-    super(TryJobs, self).__init__()
-    # An array of TryJob objects.
-    self.try_jobs = []
-    # When NOTRY=true is specified.
-    self.skipped = False
+  # An array of TryJob objects.
+  try_jobs = list
+  # When NOTRY=true is specified.
+  skipped = bool
 
   def get_state(self):
     if self.skipped:
       return base.SUCCEEDED
     if not self.try_jobs:
       return base.PROCESSING
     states = set(i.get_state() for i in self.try_jobs)
     assert states.issubset(base.VALID_STATES)
     return max(states)
 
@@ skipping 597 matching lines @@
           blame[0] == self.commit_user):
         # Note the build number to remember it started.
         logging.info('Found build %d for job %s' % (build.number, job_name))
         job.build = build.number
         return build
     return None
 
   def _patch_url(self, pending):
     return ('%s/download/issue%d_%d.diff' %
         (self.context.rietveld.url, pending.issue, pending.patchset))