Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Unified Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 11414136: Implement proposed new identity spec. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_ia32.h ('k') | runtime/vm/flow_graph_compiler_x64.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_ia32.cc
===================================================================
--- runtime/vm/flow_graph_compiler_ia32.cc (revision 15292)
+++ runtime/vm/flow_graph_compiler_ia32.cc (working copy)
@@ -1106,11 +1106,45 @@
void FlowGraphCompiler::EmitEqualityRegConstCompare(Register reg,
- const Object& obj) {
+ const Object& obj,
+ bool needs_number_check) {
+ if (needs_number_check) {
+ if (!obj.IsMint() && !obj.IsDouble() && !obj.IsBigint()) {
+ needs_number_check = false;
+ }
+ }
+
if (obj.IsSmi() && (Smi::Cast(obj).Value() == 0)) {
+ ASSERT(!needs_number_check);
__ testl(reg, reg);
+ return;
+ }
+
+ if (needs_number_check) {
+ __ pushl(reg);
+ __ PushObject(obj);
+ __ call(&StubCode::IdenticalWithNumberCheckLabel());
+ __ popl(reg); // Discard constant.
+ __ popl(reg); // Restore 'reg'.
+ return;
+ }
+
+ __ CompareObject(reg, obj);
+}
+
+
+void FlowGraphCompiler::EmitEqualityRegRegCompare(Register left,
+ Register right,
+ bool needs_number_check) {
+ if (needs_number_check) {
+ __ pushl(left);
+ __ pushl(right);
+ __ call(&StubCode::IdenticalWithNumberCheckLabel());
+ // Stub returns result in flags (result of a cmpl, we need ZF computed).
+ __ popl(right);
+ __ popl(left);
} else {
- __ CompareObject(reg, obj);
+ __ cmpl(left, right);
}
}
« no previous file with comments | « runtime/vm/flow_graph_compiler_ia32.h ('k') | runtime/vm/flow_graph_compiler_x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698