Implement proposed new identity spec.

runtime/vm/flow_graph_optimizer.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_optimizer.h"
 
 #include "vm/bit_vector.h"
 #include "vm/cha.h"
 #include "vm/flow_graph_builder.h"
 #include "vm/flow_graph_compiler.h"
@@ skipping 38 matching lines @@
     ForwardInstructionIterator it(entry);
     current_iterator_ = ⁢
     for (; !it.Done(); it.Advance()) {
       if (it.Current()->IsInstanceCall()) {
         InstanceCallInstr* call = it.Current()->AsInstanceCall();
         if (call->HasICData()) {
           if (TryCreateICData(call)) {
             VisitInstanceCall(call);
           }
         }
+      } else if (it.Current()->IsStrictCompare()) {
+        VisitStrictCompare(it.Current()->AsStrictCompare());
+      } else if (it.Current()->IsBranch()) {
+        ComparisonInstr* compare = it.Current()->AsBranch()->comparison();
+        if (compare->IsStrictCompare()) {
+          VisitStrictCompare(compare->AsStrictCompare());
+        }
       }
     }
     current_iterator_ = NULL;
   }
 }
 
 
 // Attempt to build ICData for call using propagated class-ids.
 bool FlowGraphOptimizer::TryCreateICData(InstanceCallInstr* call) {
   ASSERT(call->HasICData());
@@ skipping 1436 matching lines @@
   } else if (comparison->IsEqualityCompare()) {
     HandleEqualityCompare(this, comparison->AsEqualityCompare(), instr,
                           current_iterator());
   } else {
     ASSERT(comparison->IsStrictCompare());
     // Nothing to do.
   }
 }
 
 
+static bool MayBeBoxableNumber(intptr_t cid) {
+  return (cid == kDynamicCid) ||
+         (cid == kMintCid) ||
+         (cid == kBigintCid) ||
+         (cid == kDoubleCid);
+}
+
+
+// Check if number check is not needed.
+void FlowGraphOptimizer::VisitStrictCompare(StrictCompareInstr* instr) {
+  if (!instr->needs_number_check()) return;
+
+  // If one of the input is not a boxable number (Mint, Double, Bigint), no
+  // need for number checks.
+  if (!MayBeBoxableNumber(instr->left()->ResultCid()) ||
+      !MayBeBoxableNumber(instr->right()->ResultCid()))  {
+    instr->set_needs_number_check(false);
+  }
+}
+
+
 // SminessPropagator ensures that CheckSmis are eliminated across phis.
 class SminessPropagator : public ValueObject {
  public:
   explicit SminessPropagator(FlowGraph* flow_graph)
       : flow_graph_(flow_graph),
         known_smis_(new BitVector(flow_graph_->current_ssa_temp_index())),
         rollback_checks_(10),
         in_worklist_(NULL),
         worklist_(0) { }
 
@@ skipping 2232 matching lines @@
 
   if (FLAG_trace_constant_propagation) {
     OS::Print("\n==== After constant propagation ====\n");
     FlowGraphPrinter printer(*graph_);
     printer.PrintBlocks();
   }
 }
 
 
 }  // namespace dart