Implement proposed new identity spec.

runtime/vm/flow_graph_compiler_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/flow_graph_compiler.h"
 
 #include "lib/error.h"
@@ skipping 1088 matching lines @@
                    token_pos,
                    &StubCode::CallStaticFunctionLabel(),
                    PcDescriptors::kFuncCall,
                    locs);
   AddStaticCallTarget(function);
   __ Drop(argument_count);
 }
 
 
 void FlowGraphCompiler::EmitEqualityRegConstCompare(Register reg,
-                                                    const Object& obj) {
+                                                    const Object& obj,
+                                                    bool needs_number_check) {
+  if (needs_number_check) {
+    if (!obj.IsMint() && !obj.IsDouble() && !obj.IsBigint()) {
+      needs_number_check = false;
+    }
+  }
   if (obj.IsSmi() && (Smi::Cast(obj).Value() == 0)) {
+    ASSERT(!needs_number_check);
     __ testl(reg, reg);
   } else {

[Florian Schneider, 2012/11/23 10:33:40]

Maybe reduce the nesting level by using

} else if (needs_number_check) {

here.

[srdjan, 2012/11/23 19:45:39]

changed to use returns instead of else.

-    __ CompareObject(reg, obj);
+    if (needs_number_check) {
+      __ pushl(reg);
+      __ PushObject(obj);
+      __ call(&StubCode::IdenticalWithNumberCheckLabel());

[Florian Schneider, 2012/11/23 10:33:40]

Maybe add comment that the stub return result in the flags-register.

[srdjan, 2012/11/23 19:45:39]

Done.

+      __ popl(reg);  // Discard constant.
+      __ popl(reg);  // Restore 'reg'.
+    } else {
+      __ CompareObject(reg, obj);
+    }
+  }
+}
+
+
+void FlowGraphCompiler::EmitEqualityRegRegCompare(Register left,
+                                                  Register right,
+                                                  bool needs_number_check) {
+  if (needs_number_check) {
+    __ pushl(left);
+    __ pushl(right);
+    __ call(&StubCode::IdenticalWithNumberCheckLabel());
+    __ popl(right);
+    __ popl(left);
+  } else {
+    __ cmpl(left, right);
   }
 }
 
 
 // Implement equality spec: if any of the arguments is null do identity check.
 // Fallthrough calls super equality.
 void FlowGraphCompiler::EmitSuperEqualityCallPrologue(Register result,
                                                       Label* skip_call) {
   const Immediate raw_null =
       Immediate(reinterpret_cast<intptr_t>(Object::null()));
@@ skipping 261 matching lines @@
   __ popl(ECX);
   __ popl(EAX);
 }
 
 
 #undef __
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32