drive: Get rid of use of MockDriveUploader from c/b/c/drive

drive: Get rid of use of MockDriveUploader from c/b/c/drive

In drive_file_system_unittest.cc, what we needed was a fake, not a mock
In stale_cache_files_remover_unittest.cc, what we needed was a stub, not a mock

See also http://googletesting.blogspot.jp/2008/06/tott-friends-you-can-depend-on.html

BUG=162351
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=169223

[satorux1, 2012-11-22 05:56:52]

More code but much easier to understand!

[kinaba, 2012-11-22 06:12:13]

Not quite sure but...

https://codereview.chromium.org/11414126/diff/2001/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/drive_file_system_unittest.cc (right):

https://codereview.chromium.org/11414126/diff/2001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/drive_file_system_unittest.cc:123:
FakeDriveUploader() {};
semicolon not needed.

https://codereview.chromium.org/11414126/diff/2001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/drive_file_system_unittest.cc:124: virtual
~FakeDriveUploader() {};
ditto.

https://codereview.chromium.org/11414126/diff/2001/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/stale_cache_files_remover_unittest.cc
(right):

https://codereview.chromium.org/11414126/diff/2001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/stale_cache_files_remover_unittest.cc:55: // Stub
implementation of DriveUploaderInterface which does nothing.
After looking the code below, I've changed my mind; the class looks like
a "Dummy" rather than a "Stub" according to the referred article. :)

The xxx_uploader_ object will never even "return hard-coded values"
(NOTREACHED); rather it is passed just for satisfing the DriveFileSystem's
constructor signature.

What do you think?

https://codereview.chromium.org/11414126/diff/2001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/stale_cache_files_remover_unittest.cc:59:
StubDriveUploader() {};
Semicolon not needed.

https://codereview.chromium.org/11414126/diff/2001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/stale_cache_files_remover_unittest.cc:60: virtual
~StubDriveUploader() {};
ditto.

[satorux1, 2012-11-22 06:16:12]

https://codereview.chromium.org/11414126/diff/2001/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/drive_file_system_unittest.cc (right):

https://codereview.chromium.org/11414126/diff/2001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/drive_file_system_unittest.cc:123:
FakeDriveUploader() {};
On 2012/11/22 06:12:13, kinaba wrote:
> semicolon not needed.

Done.

https://codereview.chromium.org/11414126/diff/2001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/drive_file_system_unittest.cc:124: virtual
~FakeDriveUploader() {};
On 2012/11/22 06:12:13, kinaba wrote:
> ditto.

Done.

https://codereview.chromium.org/11414126/diff/2001/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/stale_cache_files_remover_unittest.cc
(right):

https://codereview.chromium.org/11414126/diff/2001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/stale_cache_files_remover_unittest.cc:55: // Stub
implementation of DriveUploaderInterface which does nothing.
On 2012/11/22 06:12:13, kinaba wrote:
> After looking the code below, I've changed my mind; the class looks like
> a "Dummy" rather than a "Stub" according to the referred article. :)
> 
> The xxx_uploader_ object will never even "return hard-coded values"
> (NOTREACHED); rather it is passed just for satisfing the DriveFileSystem's
> constructor signature.
> 
> What do you think?

Agreed... It's hard to distinguish those friends.

https://codereview.chromium.org/11414126/diff/2001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/stale_cache_files_remover_unittest.cc:59:
StubDriveUploader() {};
On 2012/11/22 06:12:13, kinaba wrote:
> Semicolon not needed.

Done.

https://codereview.chromium.org/11414126/diff/2001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/stale_cache_files_remover_unittest.cc:60: virtual
~StubDriveUploader() {};
On 2012/11/22 06:12:13, kinaba wrote:
> ditto.

Done.

[kinaba, 2012-11-22 06:17:57]

lgtm