src/objects.cc - Issue 11414094: Make Object.observe on the global object functional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 11414094: Make Object.observe on the global object functional (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Test with reattaching to a different context Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 05c00824009233bb90642c648d78d262f6a73e17..cb7b6eb9106583fd0c1e3e286a724e87f267aef2 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -1749,6 +1749,9 @@ void JSObject::EnqueueChangeRecord(Handle<JSObject> object,

Isolate* isolate = object->GetIsolate();

HandleScope scope;

Handle<String> type = isolate->factory()->LookupAsciiSymbol(type_str);

+ if (object->IsJSGlobalObject()) {

+ object = handle(JSGlobalObject::cast(*object)->global_receiver(), isolate);

+ }

Handle<Object> args[] = { type, object, name, old_value };

bool threw;

Execution::Call(Handle<JSFunction>(isolate->observers_notify_change()),