Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 11414048: overscroll: Add a browser-test for the aura implementation. (Closed)

Created:
8 years, 1 month ago by sadrul
Modified:
8 years, 1 month ago
Reviewers:
rjkroege, sky, Jói
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

overscroll: Add a browser-test for the aura implementation. The test verifies that overscroll performs navigation correctly on pages with and without touch event handlers. BUG=160668 TBR=joi@chromium.org (for content_tests.gypi) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168547 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168600

Patch Set 1 : . #

Total comments: 2

Patch Set 2 : . #

Patch Set 3 : disable-test-on-win-aura #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -0 lines) Patch
M build/filename_rules.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A content/browser/web_contents/web_contents_view_aura_browsertest.cc View 1 2 1 chunk +173 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/overscroll_navigation.html View 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sadrul
8 years, 1 month ago (2012-11-17 16:36:08 UTC) #1
rjkroege
On 2012/11/17 16:36:08, sadrul wrote: lgtm. this is awesome. It would be great to expand ...
8 years, 1 month ago (2012-11-19 15:33:37 UTC) #2
sky
LGTM https://codereview.chromium.org/11414048/diff/4001/content/browser/web_contents/web_contents_view_aura_browsertest.cc File content/browser/web_contents/web_contents_view_aura_browsertest.cc (right): https://codereview.chromium.org/11414048/diff/4001/content/browser/web_contents/web_contents_view_aura_browsertest.cc#newcode52 content/browser/web_contents/web_contents_view_aura_browsertest.cc:52: StartTestWithPage("files/overscroll_navigation.html"); Sine StartTestWithPage may assert you need to ...
8 years, 1 month ago (2012-11-19 17:14:35 UTC) #3
sadrul
http://codereview.chromium.org/11414048/diff/4001/content/browser/web_contents/web_contents_view_aura_browsertest.cc File content/browser/web_contents/web_contents_view_aura_browsertest.cc (right): http://codereview.chromium.org/11414048/diff/4001/content/browser/web_contents/web_contents_view_aura_browsertest.cc#newcode52 content/browser/web_contents/web_contents_view_aura_browsertest.cc:52: StartTestWithPage("files/overscroll_navigation.html"); On 2012/11/19 17:14:35, sky wrote: > Sine StartTestWithPage ...
8 years, 1 month ago (2012-11-19 17:22:00 UTC) #4
sadrul
+joi@ for OWNER stamp in content_tests.gypi (TBR'ing this change)
8 years, 1 month ago (2012-11-19 17:28:34 UTC) #5
Jói
8 years, 1 month ago (2012-11-20 11:07:27 UTC) #6
LGTM for content_tests.gypi

Powered by Google App Engine
This is Rietveld 408576698