Issue 11414041: Add function to CancelableTaskTracker and convert BootTimeLoader (take 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11414041: Add function to CancelableTaskTracker and convert BootTimeLoader (take 2) (Closed)

Created:
8 years, 1 month ago by kaiwang

Modified:
8 years, 1 month ago

Reviewers:
brettw

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add function to CancelableTaskTracker and convert BootTimeLoader (take 2) This is the second try of: https://chromiumcodereview.appspot.com/11410073 Previous code has a potential race condition: ---------------------------------------------------------------- In old code when IsCanceledCallback is deleted. CancellationFlag is deleted In task thread, and Untrack is called on client thread. There's potential racy between: 1. CancellationFlag deletion. (task thread) 2. Untrack is called. (client thread) 3. TryCancel is called for the specific task. (client thread) When the order is 1, 3, 2. There will be a CancellationFlag use after delettion bug. ---------------------------------------------------------------- BUG=155883 TBR=brettw Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168321

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+189 lines, -50 lines)			Patch
M	chrome/browser/chromeos/boot_times_loader.h	View	4 chunks	+14 lines, -18 lines	0 comments	Download
M	chrome/browser/chromeos/boot_times_loader.cc	View	7 chunks	+35 lines, -17 lines	0 comments	Download
M	chrome/browser/chromeos/login/version_info_updater.h	View	1 chunk	+5 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/login/version_info_updater.cc	View	2 chunks	+6 lines, -7 lines	0 comments	Download
M	chrome/common/cancelable_task_tracker.h	View	3 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/common/cancelable_task_tracker.cc	View	3 chunks	+48 lines, -0 lines	0 comments	Download
M	chrome/common/cancelable_task_tracker_unittest.cc	View	5 chunks	+69 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

No comments yet.

Expand Messages | Collapse Messages