[S.P.] Expand cull-rect for text boxes with selection bounds

[S.P.] Expand cull-rect for text boxes with selection bounds

Highlights for selection/composition and document markers are painted
together with actual text, so the cull rect needs to have the bounds
from these included.

TEST=editing/selection/extend-by-character-002.html
BUG=486825
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195632

[fs, 2015-05-19 21:28:22]

fs@opera.com changed reviewers:
+ chrishtr@chromium.org

[fs, 2015-05-19 21:28:22]

Get the feeling that might end up a bit whack-a-mole-ish with the all the
different code-paths (markers, decorations, rotations...)

[chrishtr, 2015-05-19 21:55:07]

https://codereview.chromium.org/1141403003/diff/20001/Source/core/paint/Inlin...
File Source/core/paint/InlineTextBoxPainter.cpp (right):

https://codereview.chromium.org/1141403003/diff/20001/Source/core/paint/Inlin...
Source/core/paint/InlineTextBoxPainter.cpp:103:
paintRect.unite(calculateSelectionBounds(LayoutRect(boxOrigin, LayoutSize(1,
1))));
m_inlineTextBox.inlineSelectionRect()?

Also, why LayoutSize(1, 1)?

[fs, 2015-05-20 14:44:09]

https://codereview.chromium.org/1141403003/diff/20001/Source/core/paint/Inlin...
File Source/core/paint/InlineTextBoxPainter.cpp (right):

https://codereview.chromium.org/1141403003/diff/20001/Source/core/paint/Inlin...
Source/core/paint/InlineTextBoxPainter.cpp:103:
paintRect.unite(calculateSelectionBounds(LayoutRect(boxOrigin, LayoutSize(1,
1))));
On 2015/05/19 21:55:07, chrishtr wrote:
> m_inlineTextBox.inlineSelectionRect()?

Assuming you meant localSelectionRect here. Done.
 
> Also, why LayoutSize(1, 1)?

Need to make sure the result didn't become (empty). Not needed with the above
though.

[chrishtr, 2015-05-20 18:08:33]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2015-05-20 18:08:33]

lgtm

[commit-bot: I haz the power, 2015-05-20 18:08:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1141403003/40001

[commit-bot: I haz the power, 2015-05-20 18:12:07]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195632