Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Issue 1141403002: Add split-select logic to apk_install.py & fix crash when --split-apk-path is used (Closed)

Created:
5 years, 7 months ago by agrieve
Modified:
5 years, 7 months ago
Reviewers:
cjhopman, jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, sadrul, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@uses-sdk-21
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add split-select logic to apk_install.py & fix crash when --split-apk-path is used This makes the script able to install the correct density-based split. BUG=447152 Committed: https://crrev.com/16cd4e3dcbac844d194be8518f9b049a35c7634e Cr-Commit-Position: refs/heads/master@{#331205}

Patch Set 1 #

Total comments: 7

Patch Set 2 : Fix style nits and add minSdkVersion check when splits are enabled #

Patch Set 3 : use constants rather than hardcoding lollipop as 21 #

Total comments: 6

Patch Set 4 : Address review nits #

Total comments: 8

Patch Set 5 : remove print, convert ShellCommannd to GetProp()s, gyp flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -6 lines) Patch
M build/android/gyp/apk_install.py View 1 2 3 4 3 chunks +53 lines, -6 lines 0 comments Download
M build/java_apk.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (3 generated)
agrieve
5 years, 7 months ago (2015-05-19 14:41:05 UTC) #2
jbudorick
+cjhopman owns b/a/gyp https://codereview.chromium.org/1141403002/diff/1/build/android/gyp/apk_install.py File build/android/gyp/apk_install.py (right): https://codereview.chromium.org/1141403002/diff/1/build/android/gyp/apk_install.py#newcode28 build/android/gyp/apk_install.py:28: SHELL_CONFIG_COMMAND = ('echo $(getprop persist.sys.language)-' I ...
5 years, 7 months ago (2015-05-19 15:06:59 UTC) #4
jbudorick
https://codereview.chromium.org/1141403002/diff/1/build/android/gyp/apk_install.py File build/android/gyp/apk_install.py (right): https://codereview.chromium.org/1141403002/diff/1/build/android/gyp/apk_install.py#newcode123 build/android/gyp/apk_install.py:123: if options.split_apk_path: This should check against a minimum SDK ...
5 years, 7 months ago (2015-05-19 15:12:48 UTC) #5
jbudorick
https://codereview.chromium.org/1141403002/diff/40001/build/android/gyp/apk_install.py File build/android/gyp/apk_install.py (right): https://codereview.chromium.org/1141403002/diff/40001/build/android/gyp/apk_install.py#newcode29 build/android/gyp/apk_install.py:29: SHELL_CONFIG_COMMAND = ('echo $(getprop persist.sys.language)-' This is kind of ...
5 years, 7 months ago (2015-05-19 18:21:59 UTC) #6
agrieve
Addressed comments. https://codereview.chromium.org/1141403002/diff/1/build/android/gyp/apk_install.py File build/android/gyp/apk_install.py (right): https://codereview.chromium.org/1141403002/diff/1/build/android/gyp/apk_install.py#newcode28 build/android/gyp/apk_install.py:28: SHELL_CONFIG_COMMAND = ('echo $(getprop persist.sys.language)-' On 2015/05/19 ...
5 years, 7 months ago (2015-05-19 18:34:53 UTC) #7
cjhopman
https://codereview.chromium.org/1141403002/diff/60001/build/android/gyp/apk_install.py File build/android/gyp/apk_install.py (right): https://codereview.chromium.org/1141403002/diff/60001/build/android/gyp/apk_install.py#newcode65 build/android/gyp/apk_install.py:65: return expected_file.read() != device.GetInstallMetadata(apk_package) Is the install metadata still ...
5 years, 7 months ago (2015-05-20 01:37:28 UTC) #8
jbudorick
https://codereview.chromium.org/1141403002/diff/60001/build/android/gyp/apk_install.py File build/android/gyp/apk_install.py (right): https://codereview.chromium.org/1141403002/diff/60001/build/android/gyp/apk_install.py#newcode33 build/android/gyp/apk_install.py:33: SHELL_CONFIG_COMMAND = ('echo $(getprop persist.sys.language)-' This would seemingly be ...
5 years, 7 months ago (2015-05-20 01:43:06 UTC) #9
jbudorick
https://codereview.chromium.org/1141403002/diff/60001/build/android/gyp/apk_install.py File build/android/gyp/apk_install.py (right): https://codereview.chromium.org/1141403002/diff/60001/build/android/gyp/apk_install.py#newcode33 build/android/gyp/apk_install.py:33: SHELL_CONFIG_COMMAND = ('echo $(getprop persist.sys.language)-' On 2015/05/20 01:43:05, jbudorick ...
5 years, 7 months ago (2015-05-20 01:44:06 UTC) #10
agrieve
addressed comments. https://codereview.chromium.org/1141403002/diff/60001/build/android/gyp/apk_install.py File build/android/gyp/apk_install.py (right): https://codereview.chromium.org/1141403002/diff/60001/build/android/gyp/apk_install.py#newcode33 build/android/gyp/apk_install.py:33: SHELL_CONFIG_COMMAND = ('echo $(getprop persist.sys.language)-' On 2015/05/20 ...
5 years, 7 months ago (2015-05-20 14:33:58 UTC) #11
agrieve
On 2015/05/20 14:33:58, agrieve wrote: > addressed comments. > > https://codereview.chromium.org/1141403002/diff/60001/build/android/gyp/apk_install.py > File build/android/gyp/apk_install.py (right): ...
5 years, 7 months ago (2015-05-22 18:23:27 UTC) #12
jbudorick
lgtm not an owner in build/, though.
5 years, 7 months ago (2015-05-22 20:13:22 UTC) #13
cjhopman
lgtm
5 years, 7 months ago (2015-05-22 20:14:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141403002/80001
5 years, 7 months ago (2015-05-22 20:18:30 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 7 months ago (2015-05-22 23:35:26 UTC) #17
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 23:36:12 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/16cd4e3dcbac844d194be8518f9b049a35c7634e
Cr-Commit-Position: refs/heads/master@{#331205}

Powered by Google App Engine
This is Rietveld 408576698