Issue 11414027: Fixed gtest_mac.mm after gtest roll to 621. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(120)

My Issues | Starred Open | Closed | All

Issue 11414027: Fixed gtest_mac.mm after gtest roll to 621. (Closed)

Created:
8 years, 1 month ago by Joao da Silva

Modified:
8 years, 1 month ago

Reviewers:
Robert Sesek

CC:
chromium-reviews, sail+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixed gtest_mac.mm after gtest roll to 621. The issue is caused by the removal of the String(const char*) ctor in http://git.chromium.org/gitweb/?p=external/gtest.git;a=blobdiff;f=include/gtest/internal/gtest-string.h;h=472dd0583917c2ad786dbe4711b53fcadb772d3a;hp=967b11738ef234aa09e3879d98e77c7277e2d3c3;hb=03c314931649a999b0cf5deb0a434a1009157416;hpb=5d9f11fe81eaca3989ec7e8dbfe5b31608a75121. TBR=rsesek Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168183

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	testing/gtest_mac.mm	View		3 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages

Powered by Google App Engine

This is Rietveld 408576698