[zoom bubble] Add tests for ZoomController::UpdateState() handling empty hosts.

chrome/browser/ui/zoom/zoom_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/zoom/zoom_controller.h"
 
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/tab_contents/tab_contents.h"
@@ skipping 58 matching lines @@
   UpdateState(*content::Details<std::string>(details).ptr());
 }
 
 void ZoomController::OnPreferenceChanged(PrefServiceBase* service,
                                          const std::string& pref_name) {
   DCHECK(pref_name == prefs::kDefaultZoomLevel);
   UpdateState(std::string());
 }
 
 void ZoomController::UpdateState(const std::string& host) {
-  if (host.empty())
-    return;
-
   CHECK(web_contents());  // http://crbug.com/144879
 
-  // Use the active navigation entry's URL instead of the WebContents' so
-  // virtual URLs work (e.g. chrome://settings). http://crbug.com/153950
-  content::NavigationEntry* active_entry =
-      web_contents()->GetController().GetActiveEntry();
-  if (!active_entry ||
-      host != net::GetHostOrSpecFromURL(active_entry->GetURL())) {
-    return;
+  // If |host| is empty, all observers should be updated.
+  if (!host.empty()) {

[Dan Beam, 2012/11/16 04:17:48]

I included this diff (from: https://codereview.chromium.org/11299014/) so I can
try the logic while that CL isn't landed, you can just ignore and I'll rebase
before landing.

+    // Use the active navigation entry's URL instead of the WebContents' so
+    // virtual URLs work (e.g. chrome://settings). http://crbug.com/153950
+    content::NavigationEntry* active_entry =
+        web_contents()->GetController().GetActiveEntry();
+    if (!active_entry ||
+        host != net::GetHostOrSpecFromURL(active_entry->GetURL())) {
+      return;
+    }
   }
 
   bool dummy;
   zoom_percent_ = web_contents()->GetZoomPercent(&dummy, &dummy);
 
   if (observer_)
     observer_->OnZoomChanged(web_contents(), !host.empty());
 }