Depend on stored sync session GUID for Android.

Depend on stored sync session GUID for Android.

This changes the Android port of Chrome to depend on the pref
kSyncSessionsGUID to be set before the SessionModelAssociator is
initialized.

We now also force-removes any foreign sessions that are using the
current client's GUID as a session tag.

This also lead to the removal of the Android specific session utils.

BUG=157419
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171109

[nyquist, 2012-11-15 19:33:54]

zea: PTAL

[Nicolas Zea, 2012-11-16 18:55:20]

https://codereview.chromium.org/11414013/diff/1/chrome/browser/sync/glue/sess...
File chrome/browser/sync/glue/session_model_associator.cc (right):

https://codereview.chromium.org/11414013/diff/1/chrome/browser/sync/glue/sess...
chrome/browser/sync/glue/session_model_associator.cc:645: std::string
persisted_machine_tag;
I don't think you need this variable, doesn't current_machine_tag_ already hold
the same string?

https://codereview.chromium.org/11414013/diff/1/chrome/browser/sync/glue/sess...
chrome/browser/sync/glue/session_model_associator.cc:1281: std::string
SessionModelAssociator::GetMachineTagFromTransaction(
Since this is basically a static helper method, I think having it at the top of
the file in an anon namespace is better than a private member.

https://codereview.chromium.org/11414013/diff/1/chrome/browser/sync/glue/sess...
File chrome/browser/sync/glue/session_model_associator.h (right):

https://codereview.chromium.org/11414013/diff/1/chrome/browser/sync/glue/sess...
chrome/browser/sync/glue/session_model_associator.h:478: std::string
GetMachineTagFromTransaction(syncer::WriteTransaction* trans);
this can be an anon namespace method in the cc file.

[nyquist, 2012-12-04 01:55:05]

zea: PTAL

https://codereview.chromium.org/11414013/diff/1/chrome/browser/sync/glue/sess...
File chrome/browser/sync/glue/session_model_associator.cc (right):

https://codereview.chromium.org/11414013/diff/1/chrome/browser/sync/glue/sess...
chrome/browser/sync/glue/session_model_associator.cc:645: std::string
persisted_machine_tag;
On 2012/11/16 18:55:20, Nicolas Zea wrote:
> I don't think you need this variable, doesn't current_machine_tag_ already
hold
> the same string?

Done.

https://codereview.chromium.org/11414013/diff/1/chrome/browser/sync/glue/sess...
chrome/browser/sync/glue/session_model_associator.cc:1281: std::string
SessionModelAssociator::GetMachineTagFromTransaction(
On 2012/11/16 18:55:20, Nicolas Zea wrote:
> Since this is basically a static helper method, I think having it at the top
of
> the file in an anon namespace is better than a private member.

Done.

https://codereview.chromium.org/11414013/diff/1/chrome/browser/sync/glue/sess...
File chrome/browser/sync/glue/session_model_associator.h (right):

https://codereview.chromium.org/11414013/diff/1/chrome/browser/sync/glue/sess...
chrome/browser/sync/glue/session_model_associator.h:478: std::string
GetMachineTagFromTransaction(syncer::WriteTransaction* trans);
On 2012/11/16 18:55:20, Nicolas Zea wrote:
> this can be an anon namespace method in the cc file.

Done.

[Nicolas Zea, 2012-12-04 18:14:31]

lgtm

[commit-bot: I haz the power, 2012-12-04 21:00:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nyquist@chromium.org/11414013/5001

[commit-bot: I haz the power, 2012-12-05 01:15:23]

Change committed as 171109