Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4184)

Unified Diff: chrome/renderer/plugins/plugin_placeholder.cc

Issue 11414010: Add placeholder text for unsupported plug-ins. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/chrome_content_renderer_client.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/plugins/plugin_placeholder.cc
diff --git a/chrome/renderer/plugins/plugin_placeholder.cc b/chrome/renderer/plugins/plugin_placeholder.cc
index 4590a92726955f4caa19e69da8ff9c808b56b6a8..0a1e2b0ac31aad3077a91015484290e009d191ea 100644
--- a/chrome/renderer/plugins/plugin_placeholder.cc
+++ b/chrome/renderer/plugins/plugin_placeholder.cc
@@ -109,7 +109,12 @@ PluginPlaceholder* PluginPlaceholder::CreateMissingPlugin(
IDR_BLOCKED_PLUGIN_HTML));
DictionaryValue values;
+#if defined(ENABLE_PLUGIN_INSTALLATION)
values.SetString("message", l10n_util::GetStringUTF8(IDS_PLUGIN_SEARCHING));
+#else
+ values.SetString("message",
+ l10n_util::GetStringUTF8(IDS_PLUGIN_NOT_SUPPORTED));
+#endif
std::string html_data =
jstemplate_builder::GetI18nTemplateHtml(template_html, &values);
@@ -122,8 +127,6 @@ PluginPlaceholder* PluginPlaceholder::CreateMissingPlugin(
RenderThread::Get()->Send(new ChromeViewHostMsg_FindMissingPlugin(
missing_plugin->routing_id(), missing_plugin->CreateRoutingId(),
params.mimeType.utf8()));
-#else
- missing_plugin->OnDidNotFindMissingPlugin();
#endif
return missing_plugin;
}
« no previous file with comments | « chrome/renderer/chrome_content_renderer_client.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698