Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1431)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11414010: Add placeholder text for unsupported plug-ins. (Closed)

Created:
8 years, 1 month ago by newt (away)
Modified:
8 years ago
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Add placeholder text for unsupported plug-ins. On platforms that don't support installing plug-ins, show a "plug-in unsupported" message instead of a "missing plug-in" message. BUG=158871 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171021

Patch Set 1 #

Total comments: 2

Patch Set 2 : OnDidNotFindMissingPlugin moved inside ENABLE_PLUGIN_INSTALLATION #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/plugins/plugin_placeholder.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/plugins/plugin_placeholder.cc View 1 2 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
newt (away)
8 years, 1 month ago (2012-11-17 00:16:47 UTC) #1
newt (away)
PTAL
8 years ago (2012-11-29 22:47:08 UTC) #2
Bernhard Bauer
https://codereview.chromium.org/11414010/diff/1/chrome/renderer/plugins/plugin_placeholder.cc File chrome/renderer/plugins/plugin_placeholder.cc (right): https://codereview.chromium.org/11414010/diff/1/chrome/renderer/plugins/plugin_placeholder.cc#newcode413 chrome/renderer/plugins/plugin_placeholder.cc:413: void PluginPlaceholder::OnDidNotFindMissingPlugin() { Could you move this into the ...
8 years ago (2012-11-30 14:58:32 UTC) #3
newt (away)
Comment addressed. PTAL.
8 years ago (2012-11-30 19:41:00 UTC) #4
newt (away)
https://codereview.chromium.org/11414010/diff/1/chrome/renderer/plugins/plugin_placeholder.cc File chrome/renderer/plugins/plugin_placeholder.cc (right): https://codereview.chromium.org/11414010/diff/1/chrome/renderer/plugins/plugin_placeholder.cc#newcode413 chrome/renderer/plugins/plugin_placeholder.cc:413: void PluginPlaceholder::OnDidNotFindMissingPlugin() { On 2012/11/30 14:58:33, Bernhard Bauer wrote: ...
8 years ago (2012-11-30 19:41:18 UTC) #5
Bernhard Bauer
lgtm
8 years ago (2012-11-30 19:44:09 UTC) #6
newt (away)
+ben for generated_resources.grd
8 years ago (2012-11-30 19:45:47 UTC) #7
Ben Goodger (Google)
lgtm
8 years ago (2012-12-02 02:20:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/11414010/8001
8 years ago (2012-12-03 17:46:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/11414010/8001
8 years ago (2012-12-03 18:51:10 UTC) #10
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests
8 years ago (2012-12-04 02:37:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/11414010/8001
8 years ago (2012-12-04 04:48:53 UTC) #12
commit-bot: I haz the power
8 years ago (2012-12-04 08:13:36 UTC) #13 
Retried try job too often on mac_rel for step(s) browser_tests

Powered by Google App Engine
This is Rietveld 408576698