Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1141383003: Removed project_bases from Chromium (Closed)

Created:
5 years, 7 months ago by Sergiy Byelozyorov
Modified:
5 years, 7 months ago
Reviewers:
Adrian Kuegel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed project_bases from Chromium They are not needed since Chromium has been moved to Git and no relpath needs to be computed anymore. R=akuegel@chromium.org BUG=471767 Committed: https://crrev.com/1c43746da3ac108197c7ab645b366e730d9e45d6 Cr-Commit-Position: refs/heads/master@{#330526}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M testing/commit_queue/config.json View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Sergiy Byelozyorov
5 years, 7 months ago (2015-05-19 12:49:12 UTC) #1
Adrian Kuegel
lgtm
5 years, 7 months ago (2015-05-19 12:52:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141383003/1
5 years, 7 months ago (2015-05-19 13:54:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141383003/1
5 years, 7 months ago (2015-05-19 14:18:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141383003/1
5 years, 7 months ago (2015-05-19 14:25:58 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 17:02:00 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 17:03:41 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c43746da3ac108197c7ab645b366e730d9e45d6
Cr-Commit-Position: refs/heads/master@{#330526}

Powered by Google App Engine
This is Rietveld 408576698