Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1141323002: Drop ImageLoader::sourceURI (Closed)

Created:
5 years, 7 months ago by fs
Modified:
5 years, 7 months ago
CC:
blink-reviews, tyoshino+watch_chromium.org, krit, blink-reviews-html_chromium.org, rwlbuis, fs, kouhei+svg_chromium.org, dglazkov+blink, f(malita), gavinp+loader_chromium.org, gyuyoung2, Stephen Chennney, Nate Chapin, pdr+svgwatchlist_chromium.org, Erik Dahlström
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Drop ImageLoader::sourceURI With xml:base removed, SVGImageLoader::sourceURI can be simplified, making it the same as the HTMLImageLoader implementation. Fold into the only caller (ImageLoader::imageSourceToKURL) and remove the extension point. BUG=341854 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195465

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -20 lines) Patch
M Source/core/html/HTMLImageLoader.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLImageLoader.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/loader/ImageLoader.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/ImageLoader.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M Source/core/svg/SVGImageLoader.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGImageLoader.cpp View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
5 years, 7 months ago (2015-05-18 12:43:18 UTC) #2
kouhei (in TOK)
lgtm
5 years, 7 months ago (2015-05-18 12:44:38 UTC) #4
philipj_slow
lgtm nice!
5 years, 7 months ago (2015-05-18 13:00:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141323002/1
5 years, 7 months ago (2015-05-18 13:00:08 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 13:03:09 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195465

Powered by Google App Engine
This is Rietveld 408576698