Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: sdk/lib/_internal/compiler/implementation/resolution/members.dart

Issue 11413219: Canonicalize raw type (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comment Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/resolution/members.dart
diff --git a/sdk/lib/_internal/compiler/implementation/resolution/members.dart b/sdk/lib/_internal/compiler/implementation/resolution/members.dart
index 56f136def826ca954044af4762b4534bcc65a4f9..9e1e01859bf7060e6ed1ec4c7da2d56d676a1fc5 100644
--- a/sdk/lib/_internal/compiler/implementation/resolution/members.dart
+++ b/sdk/lib/_internal/compiler/implementation/resolution/members.dart
@@ -1142,14 +1142,18 @@ class TypeResolver {
type = new MalformedType(
new MalformedTypeElement(node, element));
} else {
- type = new InterfaceType(cls.declaration, arguments);
+ if (arguments.isEmpty) {
+ // Use the canonical raw type if the class is generic.
+ type = cls.rawType;
ahe 2012/11/29 10:09:08 cls.declaration.rawType?
+ } else {
+ type = new InterfaceType(cls.declaration, arguments);
+ }
}
}
} else if (element.isTypedef()) {
TypedefElement typdef = element;
// TODO(ahe): Should be [ensureResolved].
compiler.resolveTypedef(typdef);
- typdef.computeType(compiler);
Link<DartType> arguments = resolveTypeArguments(
node, typdef.typeVariables, inStaticContext,
scope, onFailure, whenResolved);
@@ -1157,7 +1161,11 @@ class TypeResolver {
// Return the canonical type if it has no type parameters.
type = typdef.computeType(compiler);
} else {
- type = new TypedefType(typdef, arguments);
+ if (arguments.isEmpty) {
+ type = typdef.rawType;
+ } else {
+ type = new TypedefType(typdef, arguments);
+ }
}
} else if (element.isTypeVariable()) {
if (inStaticContext) {
@@ -1967,7 +1975,7 @@ class ResolverVisitor extends CommonResolverVisitor<Element> {
void handleRedirectingFactoryBody(Return node) {
Element redirectionTarget = resolveRedirectingFactory(node);
var type = mapping.getType(node.expression);
- if (type is InterfaceType && !type.typeArguments.isEmpty) {
+ if (type is InterfaceType && !type.isRaw) {
unimplemented(node.expression, 'type arguments on redirecting factory');
}
useElement(node.expression, redirectionTarget);
@@ -2557,8 +2565,7 @@ class ClassResolverVisitor extends TypeDefinitionVisitor {
} else {
objectElement.ensureResolved(compiler);
}
- // TODO(ahe): This should be objectElement.computeType(...).
- element.supertype = new InterfaceType(objectElement);
+ element.supertype = objectElement.computeType(compiler);
}
assert(element.interfaces == null);
Link<DartType> interfaces = const Link<DartType>();

Powered by Google App Engine
This is Rietveld 408576698