Canonicalize raw type

sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library mirrors_dart2js;
 
 import 'dart:io';
 import 'dart:uri';
 
 import '../../compiler.dart' as diagnostics;
@@ skipping 1152 matching lines @@
   bool get isInterface => originalDeclaration.isInterface;
 
   bool get isAbstract => originalDeclaration.isAbstract;
 
   bool get isPrivate => originalDeclaration.isPrivate;
 
   bool get isOriginalDeclaration => false;
 
   List<TypeMirror> get typeArguments {
     if (_typeArguments == null) {
       _typeArguments = <TypeMirror>[];

[ahe, 2012/11/29 10:09:08]

This list is not immutable.  Also, you can share a const empty array for the
common case: raw or non-generic.

-      Link<DartType> type = _interfaceType.typeArguments;
-      while (type != null && type.head != null) {
-        _typeArguments.add(_convertTypeToTypeMirror(mirrors, type.head,
-            mirrors.compiler.types.dynamicType));
-        type = type.tail;
+      if (!_interfaceType.isRaw) {
+        Link<DartType> type = _interfaceType.typeArguments;
+        while (type != null && type.head != null) {
+          _typeArguments.add(_convertTypeToTypeMirror(mirrors, type.head,
+              mirrors.compiler.types.dynamicType));
+          type = type.tail;
+        }
       }
     }
     return _typeArguments;
   }
 
   List<TypeVariableMirror> get typeVariables =>
       originalDeclaration.typeVariables;
 
   // TODO(johnniwinther): Substitute type arguments for type variables.
   Map<String, MethodMirror> get constructors =>
@@ skipping 364 matching lines @@
     var node = _variable.variables.parseNode(_diagnosticListener);
     if (node != null) {
       var span = mirrors.compiler.spanFromNode(node, script.uri);
       return new Dart2JsSourceLocation(script, span);
     } else {
       var span = mirrors.compiler.spanFromElement(_variable);
       return new Dart2JsSourceLocation(script, span);
     }
   }
 }