Instant API: tell page whether the browser is capturing key strokes.

chrome/common/instant_types.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_INSTANT_TYPES_H_
 #define CHROME_COMMON_INSTANT_TYPES_H_
 
 #include <string>
 
 #include "base/string16.h"
@@ skipping 125 matching lines @@
   ThemeBackgroundImageAlignment image_vertical_alignment;
 
   // The theme background image tiling is only valid if |theme_id| is valid.
   ThemeBackgroundImageTiling image_tiling;
 
   // The theme background image height.
   // Value is only valid if |theme_id| is valid.
   uint16 image_height;
 };
 
+// Omnibox focus state as tracked by InstantController.
+enum OmniboxFocusState {
+  FOCUS_NONE,  // Not focused.

[sky, 2012/12/10 15:15:39]

Name this enums more specifically, eg OMNIBOX_FOCUS_STATE_NONE and
OMNIBOX_FOCUS_CHANGE_EXPLICIT. Also, why are these enums here and not in the
omnibox code?

[samarth, 2012/12/10 23:45:00]

Done.
This definitely doesn't belong in instant_types anymore since as Peter
suggested, I'm using these types directly in OmniboxEditModel. I could add them
as public enums in OmniboxEditModel but then InstantController needs to pull in
all of omnibox_edit_model.h.  I assume that's bad (let me know if it isn't), so
I pulled this out into chrome/common/omnibox_types.h.

[sky, 2012/12/11 00:12:45]

This is specific to the omnibox, it should be in that directory. In general
chrome/common isn't meant to be a random grab bag of stuff.

I would put the constants in either omnibox_edit_model.h or
c/b/ui/omnibox_types.h. I would ping Peter for his preference for these.

+  FOCUS_VISIBLE,  // Visibily focused.
+  FOCUS_INVISIBLE,  // Invisibly focused, i.e. focused with a hidden caret.
+};
+
+// Reasons why focus state could change.
+enum OmniboxFocusChangeReason {
+  // Includes any explicit changes to focus. (e.g. user clicking to change
+  // focus, user tabbing to change focus, any explicit calls to SetFocus, etc.)
+  FOCUS_CHANGE_EXPLICIT,
+
+  // Focus changed to restore state from a tab the user switched to.
+  FOCUS_CHANGE_TAB_SWITCH,
+
+  // Focus changed because user started typing. This only happens when focus
+  // state is INVISIBLE (and this results in a change to VISIBLE).
+  FOCUS_CHANGE_TYPING,
+};
+
 #endif  // CHROME_COMMON_INSTANT_TYPES_H_